Skip to content

feat: add USDC and USDT payment assets for multiple networks (PAY-52)#4702

Merged
rtomas merged 2 commits intomainfrom
devin/PAY-52-1753300573
Jul 24, 2025
Merged

feat: add USDC and USDT payment assets for multiple networks (PAY-52)#4702
rtomas merged 2 commits intomainfrom
devin/PAY-52-1753300573

Conversation

@devin-ai-integration
Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration bot commented Jul 23, 2025

Description

This PR adds new payment asset definitions for USDC and USDT tokens across multiple blockchain networks to the @reown/appkit-pay library. The implementation follows the existing baseUSDC pattern and uses the requested naming convention [network][TOKEN].

Changes Made

  • Added 5 USDC assets: Ethereum, Optimism, Arbitrum, Polygon, and Solana
  • Added 5 USDT assets: Ethereum, Optimism, Arbitrum, Polygon, and Solana
  • Consistent naming: Used ethereumUSDC, optimismUSDT, etc. format
  • Standard metadata: 6 decimals for both USDC and USDT, standard token names

Type of change

  • New feature (non-breaking change which adds functionality)

Associated Issues

Closes PAY-52

Key Areas for Review

⚠️ Critical: Please verify the following contract addresses are correct:

USDC Addresses:

  • Ethereum: 0xA0b86991c6218b36c1d19D4a2e9Eb0cE3606eB48
  • Optimism: 0x0b2c639c533813f4aa9d7837caf62653d097ff85
  • Arbitrum: 0xaf88d065e77c8cC2239327C5EDb3A432268e5831
  • Polygon: 0x3c499c542cef5e3811e1192ce70d8cc03d5c3359
  • Solana: EPjFWdd5AufqSSqeM2qN1xzybapC8G4wEGGkZwyTDt1v

USDT Addresses:

  • Ethereum: 0xdAC17F958D2ee523a2206206994597C13D831ec7
  • Optimism: 0x94b008aA00579c1307B0EF2c499aD98a8ce58e58
  • Arbitrum: 0xFd086bC7CD5C481DCC9C85ebE478A1C0b69FCbb9
  • Polygon: 0xc2132d05d31c914a87c6611c10748aeb04b58e8f
  • Solana: Es9vMFrzaCERmJfrF4H2FYD4KCoNkY11McCe8BenwNYB

Open Questions (from ticket)

  1. Binance section: The ticket mentions adding assets for "Binance" but it's unclear if this refers to BNB Smart Chain or Binance exchange integration
  2. Polygon USDC: There may be a discrepancy between two USDC addresses in the codebase - using the specified address based on web3modal-api constants
  3. Naming convention: Confirm the [network][TOKEN] pattern is appropriate

Human Review Checklist

  • Contract addresses verified against official token registries for each network
  • Network IDs confirmed to match intended blockchains (eip155:1 = Ethereum, etc.)
  • Token metadata accuracy - decimals, names, symbols are correct for each network
  • Solana addresses validated using Solana-specific tools/explorers
  • No conflicts with existing asset definitions
  • Exports accessibility confirmed via packages/pay/exports/index.ts
  • Build and formatting passed (already verified)

Link to Devin run: https://app.devin.ai/sessions/dc756cccd85841e296f50ff025ba3f02
Requested by: TomTom (tomas.rawski@reown.com)

- Add USDC assets for Ethereum, Optimism, Arbitrum, Polygon, and Solana
- Add USDT assets for Ethereum, Optimism, Arbitrum, Polygon, and Solana
- Follow existing baseUSDC pattern with network, asset, and metadata fields
- Use naming convention [network][TOKEN] (e.g., ethereumUSDC, optimismUSDT)
- Addresses PAY-52 ticket requirements

Co-Authored-By: TomTom <tomtom@reown.com>
@devin-ai-integration
Copy link
Copy Markdown
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@linear
Copy link
Copy Markdown

linear bot commented Jul 23, 2025

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Jul 23, 2025

⚠️ No Changeset found

Latest commit: 46d5529

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link
Copy Markdown

vercel bot commented Jul 23, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
appkit-basic-html ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 24, 2025 8:43pm
appkit-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 24, 2025 8:43pm
appkit-gallery ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 24, 2025 8:43pm
appkit-laboratory ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 24, 2025 8:43pm
10 Skipped Deployments
Name Status Preview Comments Updated (UTC)
appkit-basic-example ⬜️ Ignored (Inspect) Jul 24, 2025 8:43pm
appkit-basic-sign-client-example ⬜️ Ignored (Inspect) Jul 24, 2025 8:43pm
appkit-basic-up-example ⬜️ Ignored (Inspect) Jul 24, 2025 8:43pm
appkit-ethers5-bera ⬜️ Ignored (Inspect) Jul 24, 2025 8:43pm
appkit-nansen-demo ⬜️ Ignored (Inspect) Jul 24, 2025 8:43pm
appkit-vue-solana ⬜️ Ignored (Inspect) Jul 24, 2025 8:43pm
appkit-wagmi-cdn-example ⬜️ Ignored (Inspect) Jul 24, 2025 8:43pm
ethereum-provider-wagmi-example ⬜️ Ignored (Inspect) Jul 24, 2025 8:43pm
next-wagmi-solana-bitcoin-example ⬜️ Ignored (Inspect) Jul 24, 2025 8:43pm
vue-wagmi-example ⬜️ Ignored (Inspect) Jul 24, 2025 8:43pm

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 23, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 77.57% 31772 / 40958
🔵 Statements 77.57% 31772 / 40958
🔵 Functions 69% 2623 / 3801
🔵 Branches 84.38% 6688 / 7926
File CoverageNo changed files found.
Generated in workflow #13753 for commit 46d5529 by the Vitest Coverage Report Action

@rtomas rtomas enabled auto-merge July 24, 2025 20:37
@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages bot commented Jul 24, 2025

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
pay-test-exchange 46d5529 Jul 24 2025, 08:43 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants