You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The reason will be displayed to describe this comment to others. Learn more.
Bug: UniversalConnectorProvider: Unnecessary Re-renders and Error Handling
The useEffect in UniversalConnectorProvider uses [props] as a dependency. Due to ...props destructuring, props is a new object reference on every render, causing the effect to run unnecessarily and potentially re-initialize the UniversalConnector. Additionally, the useEffect lacks error handling for the memoizeCreateUniversalConnector promise. If initialization fails, the component will remain in a perpetual loading state (isReady stays false) without error indication or recovery.
The reason will be displayed to describe this comment to others. Learn more.
Bug: Memoization Ignores Config Changes
The memoizeCreateUniversalConnector function uses a global cache and only initializes the connector once, ignoring subsequent config changes. Consequently, if called with different configurations (e.g., from multiple UniversalConnectorProvider instances or updated props), it returns the connector initialized with the first config, leading to outdated or incorrect configuration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
/reactexport touniversal-connectorwith a React context and provider serving the connectorType of change
Associated Issues
Closes APKT-3375
Checklist