Skip to content

fix: retain network state and session when cancelling SIWX on mobile#4717

Merged
0xmkh merged 4 commits intomainfrom
fix/siwx-message-mobile
Jul 29, 2025
Merged

fix: retain network state and session when cancelling SIWX on mobile#4717
0xmkh merged 4 commits intomainfrom
fix/siwx-message-mobile

Conversation

@0xmkh
Copy link
Copy Markdown
Collaborator

@0xmkh 0xmkh commented Jul 25, 2025

Description

Fixed an issue where cancelling a SIWX message on mobile would reset the network state and log the user out

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-3146

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

@linear
Copy link
Copy Markdown

linear bot commented Jul 25, 2025

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Jul 25, 2025

🦋 Changeset detected

Latest commit: 03e868a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 25 packages
Name Type
@reown/appkit-adapter-wagmi Patch
pay-test-exchange Patch
@reown/appkit-controllers Patch
@reown/appkit-scaffold-ui Patch
@reown/appkit Patch
@reown/appkit-adapter-bitcoin Patch
@reown/appkit-adapter-ethers Patch
@reown/appkit-adapter-ethers5 Patch
@reown/appkit-adapter-solana Patch
@reown/appkit-utils Patch
@reown/appkit-cdn Patch
@reown/appkit-cli Patch
@reown/appkit-codemod Patch
@reown/appkit-common Patch
@reown/appkit-core Patch
@reown/appkit-experimental Patch
@reown/appkit-pay Patch
@reown/appkit-polyfills Patch
@reown/appkit-siwe Patch
@reown/appkit-siwx Patch
@reown/appkit-testing Patch
@reown/appkit-ui Patch
@reown/appkit-universal-connector Patch
@reown/appkit-wallet Patch
@reown/appkit-wallet-button Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link
Copy Markdown

vercel bot commented Jul 25, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
appkit-basic-html 🛑 Canceled (Inspect) Jul 29, 2025 9:20am
appkit-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 29, 2025 9:20am
appkit-gallery ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 29, 2025 9:20am
appkit-laboratory ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 29, 2025 9:20am
10 Skipped Deployments
Name Status Preview Comments Updated (UTC)
appkit-basic-example ⬜️ Ignored (Inspect) Jul 29, 2025 9:20am
appkit-basic-sign-client-example ⬜️ Ignored (Inspect) Jul 29, 2025 9:20am
appkit-basic-up-example ⬜️ Ignored (Inspect) Jul 29, 2025 9:20am
appkit-ethers5-bera ⬜️ Ignored (Inspect) Jul 29, 2025 9:20am
appkit-nansen-demo ⬜️ Ignored (Inspect) Jul 29, 2025 9:20am
appkit-vue-solana ⬜️ Ignored (Inspect) Jul 29, 2025 9:20am
appkit-wagmi-cdn-example ⬜️ Ignored (Inspect) Jul 29, 2025 9:20am
ethereum-provider-wagmi-example ⬜️ Ignored (Inspect) Jul 29, 2025 9:20am
next-wagmi-solana-bitcoin-example ⬜️ Ignored (Inspect) Jul 29, 2025 9:20am
vue-wagmi-example ⬜️ Ignored (Inspect) Jul 29, 2025 9:20am

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 25, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 77.57% 31785 / 40972
🔵 Statements 77.57% 31785 / 40972
🔵 Functions 69% 2623 / 3801
🔵 Branches 84.39% 6695 / 7933
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/controllers/src/utils/SIWXUtil.ts 75.25% 71.62% 56.52% 75.25% 40-41, 45-55, 58-59, 64-65, 71-84, 93-94, 97-98, 101-102, 105-106, 118-119, 154, 176-177, 179-180, 190-192, 195-210, 264, 287, 332-356, 447-458, 470-471, 51, 335-362
Generated in workflow #13814 for commit 03e868a by the Vitest Coverage Report Action

@0xmkh 0xmkh added this pull request to the merge queue Jul 29, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 29, 2025
@0xmkh 0xmkh added this pull request to the merge queue Jul 29, 2025
Merged via the queue into main with commit 46c064d Jul 29, 2025
41 checks passed
@0xmkh 0xmkh deleted the fix/siwx-message-mobile branch July 29, 2025 10:22
@github-actions github-actions bot mentioned this pull request Aug 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants