Skip to content

fix: reown name selection logics, fetch reown name on connection, improve ux#4723

Merged
enesozturk merged 7 commits intomainfrom
enes/apkt-3117-choose-account-name-for-wallet-is-not-setting-the-name
Jul 29, 2025
Merged

fix: reown name selection logics, fetch reown name on connection, improve ux#4723
enesozturk merged 7 commits intomainfrom
enes/apkt-3117-choose-account-name-for-wallet-is-not-setting-the-name

Conversation

@enesozturk
Copy link
Copy Markdown
Contributor

@enesozturk enesozturk commented Jul 25, 2025

Description

Fixes & refactors "Choose Name" views:

  • Not showing the suggestions, only the whatever user typed as a row (ie when you type chris, it's not showing the suggested names, only "chris.reown.id" below)
  • Shows registered names as "Available"
  • Allows same name to be registered / submit form on the UI
  • We don't call identity check on connection and also /identity not working for Reown names, it's only working for WCN names.

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-xxx
For GH issues: closes #...

Showcase (Optional)

If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

@linear
Copy link
Copy Markdown

linear bot commented Jul 25, 2025

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Jul 25, 2025

🦋 Changeset detected

Latest commit: 11395f2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 24 packages
Name Type
@reown/appkit-controllers Patch
@reown/appkit-scaffold-ui Patch
@reown/appkit Patch
@reown/appkit-ui Patch
@reown/appkit-adapter-bitcoin Patch
@reown/appkit-adapter-ethers Patch
@reown/appkit-adapter-ethers5 Patch
@reown/appkit-adapter-solana Patch
@reown/appkit-adapter-wagmi Patch
@reown/appkit-core Patch
@reown/appkit-utils Patch
@reown/appkit-siwe Patch
@reown/appkit-siwx Patch
@reown/appkit-wallet-button Patch
@reown/appkit-experimental Patch
@reown/appkit-pay Patch
@reown/appkit-universal-connector Patch
@reown/appkit-cdn Patch
@reown/appkit-testing Patch
@reown/appkit-common Patch
@reown/appkit-polyfills Patch
@reown/appkit-wallet Patch
@reown/appkit-cli Patch
@reown/appkit-codemod Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link
Copy Markdown

vercel bot commented Jul 25, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
appkit-basic-html ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 29, 2025 1:23pm
appkit-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 29, 2025 1:23pm
appkit-gallery ✅ Ready (Inspect) Visit Preview Jul 29, 2025 1:23pm
appkit-laboratory ✅ Ready (Inspect) Visit Preview Jul 29, 2025 1:23pm
10 Skipped Deployments
Name Status Preview Comments Updated (UTC)
appkit-basic-example ⬜️ Ignored (Inspect) Jul 29, 2025 1:23pm
appkit-basic-sign-client-example ⬜️ Ignored (Inspect) Jul 29, 2025 1:23pm
appkit-basic-up-example ⬜️ Ignored (Inspect) Jul 29, 2025 1:23pm
appkit-ethers5-bera ⬜️ Ignored (Inspect) Jul 29, 2025 1:23pm
appkit-nansen-demo ⬜️ Ignored (Inspect) Jul 29, 2025 1:23pm
appkit-vue-solana ⬜️ Ignored (Inspect) Jul 29, 2025 1:23pm
appkit-wagmi-cdn-example ⬜️ Ignored (Inspect) Jul 29, 2025 1:23pm
ethereum-provider-wagmi-example ⬜️ Ignored (Inspect) Jul 29, 2025 1:23pm
next-wagmi-solana-bitcoin-example ⬜️ Ignored (Inspect) Jul 29, 2025 1:23pm
vue-wagmi-example ⬜️ Ignored (Inspect) Jul 29, 2025 1:23pm

Comment thread packages/appkit/src/client/appkit-base-client.ts
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 25, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 77.59% 31795 / 40978
🔵 Statements 77.59% 31795 / 40978
🔵 Functions 69.04% 2623 / 3799
🔵 Branches 84.37% 6697 / 7937
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/appkit/src/client/appkit-base-client.ts 72.69% 88.76% 75.79% 72.69% 183, 194-197, 207-208, 210-236, 268-269, 271-272, 277-278, 357-358, 394-400, 465-466, 495-501, 504-505, 508-509, 527-528, 543-544, 547-548, 590-591, 594, 635-639, 646-647, 650-651, 662-685, 694-695, 712-724, 728-749, 752-758, 761-767, 770-776, 779-785, 788-798, 801-807, 810-816, 832-844, 850-883, 886-896, 948-949, 954, 969-985, 999, 1003-1010, 1077-1079, 1085-1086, 1094-1095, 1097-1098, 1147-1156, 1191-1192, 1204-1205, 1210, 1233-1238, 1281, 1302-1303, 1313, 1315-1331, 1336, 1395-1406, 1452-1465, 1510, 1516-1520, 1539-1540, 1557-1560, 1596-1616, 1639-1650, 1679-1680, 1686-1712, 1920-1921, 1953-1954, 1957-1958, 1971-1974, 1977-1978, 1998-1999, 2002-2003, 2015-2025, 2043-2044, 2047-2053, 2057-2058, 2072, 2080, 2083, 2087, 2092-2111, 2114-2123, 2130-2131, 2145-2146, 2149-2150, 2157-2158, 2197-2198, 2281-2282, 2285-2286, 2289-2292, 2295-2296, 2299-2300, 2303-2304, 2307-2308, 2311-2315, 2324-2333, 2342-227, 1154, 1646, 2094-2115
packages/appkit/src/client/appkit.ts 47.15% 78.43% 82.14% 47.15% 70-117, 120-134, 137-144, 147-163, 166-178, 183-193, 199-200, 225-226, 233-234, 247-270, 278-290, 292, 294-316, 318-332, 357-363, 379, 400-401, 406-407, 422-506, 546, 552-555, 577-578, 601-603, 611-612, 651-652, 655-656, 314
packages/controllers/exports/index.ts 100% 100% 100% 100%
packages/controllers/src/controllers/EnsController.ts 82.35% 55% 66.66% 82.35% 43, 47, 78-79, 93-94, 106-108, 117-118, 121-122, 130, 136-137, 145-146, 172-174, 183-186
packages/scaffold-ui/src/views/w3m-register-account-name-view/index.ts 21.87% 100% 0% 21.87% 50-65, 69-70, 73-76, 80-100, 104-128, 143-144, 147-154, 157-176, 179-192, 195-234, 237-241
packages/scaffold-ui/src/views/w3m-register-account-name-view/styles.ts 100% 100% 100% 100%
packages/ui/src/composites/wui-icon-link/styles.ts 100% 100% 100% 100%
Generated in workflow #13826 for commit 11395f2 by the Vitest Coverage Report Action

Comment thread packages/appkit/src/client/appkit.ts
Comment thread packages/appkit/src/client/appkit-base-client.ts
@enesozturk enesozturk added this pull request to the merge queue Jul 29, 2025
@enesozturk enesozturk removed this pull request from the merge queue due to a manual request Jul 29, 2025
@enesozturk enesozturk added this pull request to the merge queue Jul 29, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 29, 2025
@enesozturk enesozturk changed the title fix: reown name selection logics, fetch reown name on connection, improve ux [do not merge] fix: reown name selection logics, fetch reown name on connection, improve ux Jul 29, 2025
@enesozturk enesozturk changed the title [do not merge] fix: reown name selection logics, fetch reown name on connection, improve ux fix: reown name selection logics, fetch reown name on connection, improve ux Jul 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants