Skip to content

chore: fix missing address in WC success event#4744

Merged
0xmkh merged 6 commits intomainfrom
fix/connect-success-event-wc
Jul 31, 2025
Merged

chore: fix missing address in WC success event#4744
0xmkh merged 6 commits intomainfrom
fix/connect-success-event-wc

Conversation

@0xmkh
Copy link
Copy Markdown
Collaborator

@0xmkh 0xmkh commented Jul 31, 2025

Description

Fixed an issue where WalletConnect connections didn't include the address value when sending the CONNECT_SUCCESS event

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-3440

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

@linear
Copy link
Copy Markdown

linear bot commented Jul 31, 2025

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Jul 31, 2025

🦋 Changeset detected

Latest commit: 24187b0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 25 packages
Name Type
pay-test-exchange Patch
@reown/appkit-adapter-bitcoin Patch
@reown/appkit-adapter-ethers Patch
@reown/appkit-adapter-ethers5 Patch
@reown/appkit-adapter-solana Patch
@reown/appkit-adapter-wagmi Patch
@reown/appkit Patch
@reown/appkit-utils Patch
@reown/appkit-cdn Patch
@reown/appkit-cli Patch
@reown/appkit-codemod Patch
@reown/appkit-common Patch
@reown/appkit-controllers Patch
@reown/appkit-core Patch
@reown/appkit-experimental Patch
@reown/appkit-pay Patch
@reown/appkit-polyfills Patch
@reown/appkit-scaffold-ui Patch
@reown/appkit-siwe Patch
@reown/appkit-siwx Patch
@reown/appkit-testing Patch
@reown/appkit-ui Patch
@reown/appkit-universal-connector Patch
@reown/appkit-wallet Patch
@reown/appkit-wallet-button Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link
Copy Markdown

vercel bot commented Jul 31, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
appkit-basic-html ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 31, 2025 3:19pm
appkit-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 31, 2025 3:19pm
appkit-gallery ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 31, 2025 3:19pm
appkit-laboratory ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 31, 2025 3:19pm
10 Skipped Deployments
Name Status Preview Comments Updated (UTC)
appkit-basic-example ⬜️ Ignored (Inspect) Jul 31, 2025 3:19pm
appkit-basic-sign-client-example ⬜️ Ignored (Inspect) Jul 31, 2025 3:19pm
appkit-basic-up-example ⬜️ Ignored (Inspect) Jul 31, 2025 3:19pm
appkit-ethers5-bera ⬜️ Ignored (Inspect) Jul 31, 2025 3:19pm
appkit-nansen-demo ⬜️ Ignored (Inspect) Jul 31, 2025 3:19pm
appkit-vue-solana ⬜️ Ignored (Inspect) Jul 31, 2025 3:19pm
appkit-wagmi-cdn-example ⬜️ Ignored (Inspect) Jul 31, 2025 3:19pm
ethereum-provider-wagmi-example ⬜️ Ignored (Inspect) Jul 31, 2025 3:19pm
next-wagmi-solana-bitcoin-example ⬜️ Ignored (Inspect) Jul 31, 2025 3:19pm
vue-wagmi-example ⬜️ Ignored (Inspect) Jul 31, 2025 3:19pm

cursor[bot]

This comment was marked as outdated.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 31, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 77.59% 31864 / 41063
🔵 Statements 77.59% 31864 / 41063
🔵 Functions 69.08% 2628 / 3804
🔵 Branches 84.51% 6748 / 7984
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/appkit/src/client/appkit-base-client.ts 72.67% 88.76% 75.79% 72.67% 183, 194-197, 207-208, 210-236, 268-269, 271-272, 277-278, 357-358, 394-400, 465-466, 495-501, 504-505, 508-509, 527-528, 543-544, 547-548, 590-591, 594, 635-639, 646-647, 650-651, 662-685, 694-695, 712-724, 728-749, 752-758, 761-767, 770-776, 779-785, 788-798, 801-807, 810-816, 832-844, 850-883, 886-896, 948-949, 954, 969-985, 999, 1003-1010, 1077-1079, 1085-1086, 1094-1095, 1097-1098, 1147-1156, 1191-1192, 1204-1205, 1210, 1233-1238, 1281, 1302-1303, 1313, 1315-1331, 1336, 1395-1406, 1452-1465, 1510, 1516-1520, 1539-1540, 1559-1562, 1598-1618, 1641-1652, 1681-1682, 1688-1714, 1922-1923, 1955-1956, 1959-1960, 1973-1976, 1979-1980, 2000-2001, 2004-2005, 2017-2027, 2045-2046, 2049-2056, 2060-2061, 2075, 2083, 2086, 2090, 2095-2114, 2117-2126, 2133-2134, 2148-2149, 2152-2153, 2160-2161, 2200-2201, 2284-2285, 2288-2289, 2292-2295, 2298-2299, 2302-2303, 2306-2307, 2310-2311, 2314-2318, 2327-2336, 2345-227, 1154, 1648, 2097-2118
packages/controllers/src/controllers/ConnectionController.ts 80.88% 80% 52.87% 80.88% 162, 217-221, 224-228, 257-261, 269-270, 277-296, 303, 311, 315, 319, 323, 327, 331, 335, 339, 370-371, 374-375, 412, 416, 450-452, 463-464, 499-500, 510-511, 513-514, 522-523, 525-526, 532-544, 385
packages/controllers/src/controllers/EventsController.ts 97.4% 96.42% 85.71% 97.4% 57-58
Generated in workflow #13895 for commit 24187b0 by the Vitest Coverage Report Action

@0xmkh 0xmkh added this pull request to the merge queue Jul 31, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 31, 2025
@0xmkh 0xmkh added this pull request to the merge queue Jul 31, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 31, 2025
@0xmkh 0xmkh enabled auto-merge July 31, 2025 15:37
@0xmkh 0xmkh added this pull request to the merge queue Jul 31, 2025
Merged via the queue into main with commit 673829b Jul 31, 2025
94 of 98 checks passed
@0xmkh 0xmkh deleted the fix/connect-success-event-wc branch July 31, 2025 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants