Skip to content

refactor: ux by reown position in the qr basic view#4753

Merged
ganchoradkov merged 10 commits intomainfrom
refactor/qr-view
Aug 8, 2025
Merged

refactor: ux by reown position in the qr basic view#4753
ganchoradkov merged 10 commits intomainfrom
refactor/qr-view

Conversation

@ganchoradkov
Copy link
Copy Markdown
Member

Description

Added ux by reown to the qr basic view so it can be displayed under the All Wallets button

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

https://linear.app/reown/issue/APKT-3175/appkit-core-ux-by-reown-in-wrong-place

Showcase (Optional)

image

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Aug 1, 2025

🦋 Changeset detected

Latest commit: 76e5318

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 25 packages
Name Type
@reown/appkit-scaffold-ui Patch
@reown/appkit Patch
pay-test-exchange Patch
@reown/appkit-adapter-bitcoin Patch
@reown/appkit-adapter-ethers Patch
@reown/appkit-adapter-ethers5 Patch
@reown/appkit-adapter-solana Patch
@reown/appkit-adapter-wagmi Patch
@reown/appkit-utils Patch
@reown/appkit-cdn Patch
@reown/appkit-cli Patch
@reown/appkit-codemod Patch
@reown/appkit-common Patch
@reown/appkit-controllers Patch
@reown/appkit-core Patch
@reown/appkit-experimental Patch
@reown/appkit-pay Patch
@reown/appkit-polyfills Patch
@reown/appkit-siwe Patch
@reown/appkit-siwx Patch
@reown/appkit-testing Patch
@reown/appkit-ui Patch
@reown/appkit-universal-connector Patch
@reown/appkit-wallet Patch
@reown/appkit-wallet-button Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link
Copy Markdown

vercel bot commented Aug 1, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
appkit-basic-html ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 8, 2025 0:15am
appkit-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 8, 2025 0:15am
appkit-gallery ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 8, 2025 0:15am
appkit-laboratory ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 8, 2025 0:15am
10 Skipped Deployments
Name Status Preview Comments Updated (UTC)
appkit-basic-example ⬜️ Ignored (Inspect) Aug 8, 2025 0:15am
appkit-basic-sign-client-example ⬜️ Ignored (Inspect) Aug 8, 2025 0:15am
appkit-basic-up-example ⬜️ Ignored (Inspect) Aug 8, 2025 0:15am
appkit-ethers5-bera ⬜️ Ignored (Inspect) Aug 8, 2025 0:15am
appkit-nansen-demo ⬜️ Ignored (Inspect) Aug 8, 2025 0:15am
appkit-vue-solana ⬜️ Ignored (Inspect) Aug 8, 2025 0:15am
appkit-wagmi-cdn-example ⬜️ Ignored (Inspect) Aug 8, 2025 0:15am
ethereum-provider-wagmi-example ⬜️ Ignored (Inspect) Aug 8, 2025 0:15am
next-wagmi-solana-bitcoin-example ⬜️ Ignored (Inspect) Aug 8, 2025 0:15am
vue-wagmi-example ⬜️ Ignored (Inspect) Aug 8, 2025 0:15am

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 1, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 77.87% 32136 / 41267
🔵 Statements 77.87% 32136 / 41267
🔵 Functions 69.67% 2661 / 3819
🔵 Branches 84.77% 6834 / 8061
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/scaffold-ui/src/views/w3m-connecting-wc-basic-view/index.ts 27.5% 100% 0% 27.5% 27-31, 34-35, 39-64, 67-74
packages/scaffold-ui/src/views/w3m-connecting-wc-view/index.ts 76.47% 62.26% 66.66% 76.47% 55-56, 64, 73, 85-86, 95, 106-107, 136-138, 157-158, 172-173, 181-182, 193, 197-200, 205, 209, 226, 230-244
Generated in workflow #14126 for commit 76e5318 by the Vitest Coverage Report Action

cursor[bot]

This comment was marked as outdated.

@ganchoradkov ganchoradkov enabled auto-merge August 5, 2025 06:49
@ganchoradkov ganchoradkov added this pull request to the merge queue Aug 5, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Aug 5, 2025
cursor[bot]

This comment was marked as outdated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants