Skip to content

refactor: add input validation to Reown name input#4763

Merged
enesozturk merged 11 commits intomainfrom
refactor/use-lowercase-on-reown-name
Aug 5, 2025
Merged

refactor: add input validation to Reown name input#4763
enesozturk merged 11 commits intomainfrom
refactor/use-lowercase-on-reown-name

Conversation

@enesozturk
Copy link
Copy Markdown
Contributor

@enesozturk enesozturk commented Aug 1, 2025

Description

Adds input validation and sanitization for the Reown name select view

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-3117
For GH issues: closes #...

Showcase (Optional)

If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Aug 1, 2025

🦋 Changeset detected

Latest commit: 7e2bc86

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 24 packages
Name Type
@reown/appkit-scaffold-ui Patch
@reown/appkit-adapter-ethers Patch
@reown/appkit-adapter-ethers5 Patch
@reown/appkit-adapter-wagmi Patch
@reown/appkit Patch
@reown/appkit-siwx Patch
@reown/appkit-cdn Patch
@reown/appkit-adapter-bitcoin Patch
@reown/appkit-adapter-solana Patch
@reown/appkit-universal-connector Patch
@reown/appkit-experimental Patch
@reown/appkit-testing Patch
@reown/appkit-common Patch
@reown/appkit-ui Patch
@reown/appkit-controllers Patch
@reown/appkit-core Patch
@reown/appkit-utils Patch
@reown/appkit-polyfills Patch
@reown/appkit-wallet Patch
@reown/appkit-siwe Patch
@reown/appkit-wallet-button Patch
@reown/appkit-cli Patch
@reown/appkit-pay Patch
@reown/appkit-codemod Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link
Copy Markdown

vercel bot commented Aug 1, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
appkit-basic-html ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 4, 2025 1:50pm
appkit-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 4, 2025 1:50pm
appkit-gallery ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 4, 2025 1:50pm
appkit-laboratory ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 4, 2025 1:50pm
10 Skipped Deployments
Name Status Preview Comments Updated (UTC)
appkit-basic-example ⬜️ Ignored (Inspect) Aug 4, 2025 1:50pm
appkit-basic-sign-client-example ⬜️ Ignored (Inspect) Aug 4, 2025 1:50pm
appkit-basic-up-example ⬜️ Ignored (Inspect) Aug 4, 2025 1:50pm
appkit-ethers5-bera ⬜️ Ignored (Inspect) Aug 4, 2025 1:50pm
appkit-nansen-demo ⬜️ Ignored (Inspect) Aug 4, 2025 1:50pm
appkit-vue-solana ⬜️ Ignored (Inspect) Aug 4, 2025 1:50pm
appkit-wagmi-cdn-example ⬜️ Ignored (Inspect) Aug 4, 2025 1:50pm
ethereum-provider-wagmi-example ⬜️ Ignored (Inspect) Aug 4, 2025 1:50pm
next-wagmi-solana-bitcoin-example ⬜️ Ignored (Inspect) Aug 4, 2025 1:50pm
vue-wagmi-example ⬜️ Ignored (Inspect) Aug 4, 2025 1:50pm

@linear
Copy link
Copy Markdown

linear bot commented Aug 1, 2025

cursor[bot]

This comment was marked as outdated.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 1, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 77.69% 31889 / 41044
🔵 Statements 77.69% 31889 / 41044
🔵 Functions 69.51% 2645 / 3805
🔵 Branches 84.66% 6790 / 8020
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/scaffold-ui/src/utils/HelpersUtil.ts 90% 85.71% 100% 90% 15-16
packages/scaffold-ui/src/views/w3m-register-account-name-view/index.ts 20.95% 100% 0% 20.95% 51-66, 70-71, 74-77, 81-102, 106-130, 145-148, 152-155, 158-165, 168-187, 190-203, 206-245, 248-252
packages/ui/src/composites/wui-ens-input/index.ts 8.1% 100% 0% 8.1% 16-67
packages/ui/src/composites/wui-input-text/index.ts 85.45% 100% 75% 85.45% 82-89
Generated in workflow #13969 for commit 7e2bc86 by the Vitest Coverage Report Action

cursor[bot]

This comment was marked as outdated.

@enesozturk enesozturk enabled auto-merge August 1, 2025 17:07
cursor[bot]

This comment was marked as outdated.

@enesozturk enesozturk force-pushed the refactor/use-lowercase-on-reown-name branch from a788b76 to 44ee69c Compare August 4, 2025 13:45
@enesozturk enesozturk added this pull request to the merge queue Aug 5, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Aug 5, 2025
@enesozturk enesozturk added this pull request to the merge queue Aug 5, 2025
Merged via the queue into main with commit 769f625 Aug 5, 2025
65 of 79 checks passed
@enesozturk enesozturk deleted the refactor/use-lowercase-on-reown-name branch August 5, 2025 10:07
This was referenced Aug 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants