Skip to content

fix: btc accounts switch#4787

Merged
ganchoradkov merged 16 commits intomainfrom
fix/btc-accounts-switch
Aug 8, 2025
Merged

fix: btc accounts switch#4787
ganchoradkov merged 16 commits intomainfrom
fix/btc-accounts-switch

Conversation

@ganchoradkov
Copy link
Copy Markdown
Member

Description

Fixed a bug with bitcoin where switching to a different network wasn't also changing the accounts. This was happening because there was no subscription to accountsChanged event in universal-provider.
Also removed custom session_event handling since UP already handles it internally

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

https://linear.app/reown/issue/APKT-3468/appkit-not-switching-account-on-btc-chainchanged

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

@vercel
Copy link
Copy Markdown

vercel bot commented Aug 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
appkit-basic-html ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 8, 2025 10:32am
appkit-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 8, 2025 10:32am
appkit-gallery ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 8, 2025 10:32am
appkit-laboratory ✅ Ready (Inspect) Visit Preview Aug 8, 2025 10:32am
10 Skipped Deployments
Name Status Preview Comments Updated (UTC)
appkit-basic-example ⬜️ Ignored (Inspect) Aug 8, 2025 10:32am
appkit-basic-sign-client-example ⬜️ Ignored (Inspect) Aug 8, 2025 10:32am
appkit-basic-up-example ⬜️ Ignored (Inspect) Aug 8, 2025 10:32am
appkit-ethers5-bera ⬜️ Ignored (Inspect) Aug 8, 2025 10:32am
appkit-nansen-demo ⬜️ Ignored (Inspect) Aug 8, 2025 10:32am
appkit-vue-solana ⬜️ Ignored (Inspect) Aug 8, 2025 10:32am
appkit-wagmi-cdn-example ⬜️ Ignored (Inspect) Aug 8, 2025 10:32am
ethereum-provider-wagmi-example ⬜️ Ignored (Inspect) Aug 8, 2025 10:32am
next-wagmi-solana-bitcoin-example ⬜️ Ignored (Inspect) Aug 8, 2025 10:32am
vue-wagmi-example ⬜️ Ignored (Inspect) Aug 8, 2025 10:32am

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Aug 6, 2025

🦋 Changeset detected

Latest commit: ce9ee5d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 25 packages
Name Type
@reown/appkit-universal-connector Patch
@reown/appkit-adapter-bitcoin Patch
@reown/appkit-adapter-ethers5 Patch
@reown/appkit-adapter-ethers Patch
@reown/appkit-adapter-solana Patch
@reown/appkit-adapter-wagmi Patch
@reown/appkit-utils Patch
@reown/appkit-controllers Patch
@reown/appkit Patch
@reown/appkit-siwe Patch
pay-test-exchange Patch
@reown/appkit-cdn Patch
@reown/appkit-cli Patch
@reown/appkit-codemod Patch
@reown/appkit-common Patch
@reown/appkit-core Patch
@reown/appkit-experimental Patch
@reown/appkit-pay Patch
@reown/appkit-polyfills Patch
@reown/appkit-scaffold-ui Patch
@reown/appkit-siwx Patch
@reown/appkit-testing Patch
@reown/appkit-ui Patch
@reown/appkit-wallet Patch
@reown/appkit-wallet-button Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ganchoradkov ganchoradkov changed the base branch from main to devin/1753947337-update-walletconnect-dependencies August 6, 2025 10:19
@ganchoradkov ganchoradkov changed the base branch from devin/1753947337-update-walletconnect-dependencies to main August 6, 2025 10:20
cursor[bot]

This comment was marked as outdated.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 6, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 77.89% 32129 / 41247
🔵 Statements 77.89% 32129 / 41247
🔵 Functions 69.71% 2661 / 3817
🔵 Branches 84.78% 6831 / 8057
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/appkit/src/client/appkit-base-client.ts 72.67% 88.76% 75.79% 72.67% 182, 193-196, 206-207, 209-235, 267-268, 270-271, 276-277, 356-357, 393-399, 464-465, 494-500, 503-504, 507-508, 526-527, 542-543, 546-547, 589-590, 593, 634-638, 645-646, 649-650, 661-684, 693-694, 711-723, 727-748, 751-757, 760-766, 769-775, 778-784, 787-797, 800-806, 809-815, 831-843, 849-882, 885-895, 947-948, 953, 968-984, 998, 1002-1009, 1076-1078, 1084-1085, 1093-1094, 1096-1097, 1146-1155, 1190-1191, 1203-1204, 1209, 1232-1237, 1280, 1301-1302, 1312, 1314-1330, 1335, 1394-1405, 1451-1464, 1509, 1515-1519, 1538-1539, 1558-1561, 1597-1616, 1639-1650, 1679-1680, 1686-1712, 1920-1921, 1953-1954, 1957-1958, 1971-1974, 1977-1978, 1998-1999, 2002-2003, 2015-2025, 2043-2044, 2047-2054, 2058-2059, 2073, 2081, 2084, 2088, 2093-2112, 2115-2124, 2131-2132, 2146-2147, 2150-2151, 2158-2159, 2198-2199, 2282-2283, 2286-2287, 2290-2293, 2296-2297, 2300-2301, 2304-2305, 2308-2309, 2312-2316, 2325-2334, 2343-226, 1153, 1646, 2095-2116
packages/appkit/src/utils/HelpersUtil.ts 82.39% 94.18% 89.47% 82.39% 150-151, 210-213, 242, 261, 270-273, 277, 300, 310-346, 369-375, 379-380
Generated in workflow #14106 for commit ce9ee5d by the Vitest Coverage Report Action

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants