Skip to content

feat: Deposit from Exchange#4798

Merged
tomiir merged 30 commits intomainfrom
tomas/apkt-3470-ui-deposit-from-exchange-screen
Aug 12, 2025
Merged

feat: Deposit from Exchange#4798
tomiir merged 30 commits intomainfrom
tomas/apkt-3470-ui-deposit-from-exchange-screen

Conversation

@tomiir
Copy link
Copy Markdown
Collaborator

@tomiir tomiir commented Aug 8, 2025

Description

  • Prunes ExchangeController
  • Adds DepositFromExchangeView that allows users to select an amount and trigger a deposit from exchange transaction
  • Adds remote config wiring

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

Closes APKT-3470
Closes APKT-3286

Showcase

Screen.Recording.2025-08-08.at.12.22.13.mov

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests) => WIP
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

@linear
Copy link
Copy Markdown

linear bot commented Aug 8, 2025

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Aug 8, 2025

🦋 Changeset detected

Latest commit: f4b9aca

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 24 packages
Name Type
@reown/appkit-utils Patch
@reown/appkit-controllers Patch
@reown/appkit-scaffold-ui Patch
@reown/appkit Patch
@reown/appkit-ui Patch
@reown/appkit-adapter-bitcoin Patch
@reown/appkit-adapter-ethers Patch
@reown/appkit-adapter-ethers5 Patch
@reown/appkit-adapter-solana Patch
@reown/appkit-adapter-wagmi Patch
@reown/appkit-siwe Patch
@reown/appkit-siwx Patch
@reown/appkit-wallet-button Patch
@reown/appkit-experimental Patch
@reown/appkit-pay Patch
@reown/appkit-core Patch
@reown/appkit-universal-connector Patch
@reown/appkit-cdn Patch
@reown/appkit-testing Patch
@reown/appkit-common Patch
@reown/appkit-polyfills Patch
@reown/appkit-wallet Patch
@reown/appkit-cli Patch
@reown/appkit-codemod Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link
Copy Markdown

vercel bot commented Aug 8, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Project Deployment Preview Comments Updated (UTC)
appkit-basic-html Ready Preview 💬 Add feedback Aug 12, 2025 9:17am
appkit-demo 🛑 Canceled Aug 12, 2025 9:17am
appkit-gallery 🛑 Canceled 💬 Add feedback Aug 12, 2025 9:17am
appkit-laboratory Ready Preview 💬 Add feedback Aug 12, 2025 9:17am
10 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
appkit-basic-example ⬜️ Ignored Aug 12, 2025 9:17am
appkit-basic-sign-client-example ⬜️ Ignored Aug 12, 2025 9:17am
appkit-basic-up-example ⬜️ Ignored Aug 12, 2025 9:17am
appkit-ethers5-bera ⬜️ Ignored Aug 12, 2025 9:17am
appkit-nansen-demo ⬜️ Ignored Aug 12, 2025 9:17am
appkit-vue-solana ⬜️ Ignored Aug 12, 2025 9:17am
appkit-wagmi-cdn-example ⬜️ Ignored Aug 12, 2025 9:17am
ethereum-provider-wagmi-example ⬜️ Ignored Aug 12, 2025 9:17am
next-wagmi-solana-bitcoin-example ⬜️ Ignored Aug 12, 2025 9:17am
vue-wagmi-example ⬜️ Ignored Aug 12, 2025 9:17am

@socket-security
Copy link
Copy Markdown

socket-security bot commented Aug 8, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updated@​babel/​runtime@​7.27.6 ⏵ 7.28.21001007894100

View full report

Comment thread packages/controllers/src/utils/ExchangeUtil.ts Outdated
Comment thread packages/appkit/src/client/appkit.ts Outdated
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 8, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 78.01% 32475 / 41624
🔵 Statements 78.01% 32475 / 41624
🔵 Functions 69.67% 2697 / 3871
🔵 Branches 84.82% 6890 / 8123
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/appkit/src/client/appkit.ts 47.34% 77.66% 82.14% 47.34% 70-117, 120-134, 137-144, 147-163, 166-178, 183-193, 199-200, 225-226, 233-234, 247-270, 278-290, 292, 294-313, 315-329, 354-360, 376, 397-398, 403-404, 419-503, 543, 549-552, 574-575, 598-600, 608-609, 644-645, 652-653, 656-657
packages/appkit/src/utils/ConfigUtil.ts 95.25% 89.42% 75.6% 95.25% 40-41, 62-63, 89-90, 103, 114-115, 128, 158, 235-236
packages/controllers/exports/index.ts 100% 100% 100% 100%
packages/controllers/src/controllers/ExchangeController.ts 96.38% 90% 63.15% 96.38% 105, 109, 122-123, 141, 153
packages/controllers/src/controllers/RouterController.ts 68.42% 79.31% 70.58% 68.42% 134-139, 141-143, 145-147, 189, 205-216, 221-227, 231-236
packages/controllers/src/utils/ConstantsUtil.ts 100% 0% 100% 100%
packages/controllers/src/utils/ExchangeUtil.ts 100% 100% 81.81% 100%
packages/scaffold-ui/src/modal/w3m-router/index.ts 61.36% 20.28% 87.5% 61.36% 36-46, 60, 69, 73, 77, 79, 83, 85, 87, 89, 91, 93, 95, 97, 99, 101, 103, 105, 107, 109, 111, 113, 115, 117, 119, 121, 123, 125, 127, 129, 131, 133, 137, 139, 141, 143, 145, 147, 149, 151, 153, 155, 157, 159, 161, 163, 165, 167, 169, 171, 173, 175, 177, 179, 181, 183, 193-194
packages/scaffold-ui/src/partials/w3m-header/index.ts 91.41% 86% 78.94% 91.41% 89, 151-152, 160, 189, 199, 217, 239, 248, 256, 260-264, 267-272
packages/scaffold-ui/src/views/w3m-deposit-from-exchange-view/index.ts 94.59% 88.23% 88.88% 94.59% 52-53, 127-133
packages/scaffold-ui/src/views/w3m-deposit-from-exchange-view/styles.ts 100% 100% 100% 100%
packages/scaffold-ui/src/views/w3m-fund-wallet-view/index.ts 79.72% 85.71% 70% 79.72% 34-36, 43-44, 52, 58-59, 79, 89-98, 117, 129-130
packages/ui/src/components/wui-icon/index.ts 95.31% 98.27% 60.67% 95.31% 16, 43, 69, 82, 84, 86
packages/ui/src/composites/wui-button/index.ts 100% 100% 100% 100%
packages/ui/src/composites/wui-button/styles.ts 100% 100% 100% 100%
packages/ui/src/composites/wui-chip-button/index.ts 100% 75% 100% 100%
packages/ui/src/utils/TypeUtil.ts 100% 100% 100% 100%
Generated in workflow #14185 for commit f4b9aca by the Vitest Coverage Report Action

Comment thread packages/appkit/src/client/appkit.ts
Comment thread packages/controllers/src/utils/TypeUtil.ts Outdated
tomiir added 5 commits August 12, 2025 11:07
…hub.com:reown-com/appkit into tomas/apkt-3470-ui-deposit-from-exchange-screen
…hub.com:reown-com/appkit into tomas/apkt-3470-ui-deposit-from-exchange-screen
@tomiir tomiir added this pull request to the merge queue Aug 12, 2025
@tomiir tomiir removed this pull request from the merge queue due to a manual request Aug 12, 2025
@tomiir tomiir merged commit ce475a4 into main Aug 12, 2025
59 of 60 checks passed
@tomiir tomiir deleted the tomas/apkt-3470-ui-deposit-from-exchange-screen branch August 12, 2025 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants