Skip to content

fix: redirect to previous screen and show proper error message if connection request was rejected on mobile#4819

Merged
0xmkh merged 5 commits intomainfrom
fix/wc-mobile-ux
Aug 13, 2025
Merged

fix: redirect to previous screen and show proper error message if connection request was rejected on mobile#4819
0xmkh merged 5 commits intomainfrom
fix/wc-mobile-ux

Conversation

@0xmkh
Copy link
Copy Markdown
Collaborator

@0xmkh 0xmkh commented Aug 12, 2025

Description

Fixed an issue where rejecting a connection request from a mobile wallet would not redirect back to the previous screen to allow re-initiating the connection

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-3181
For GH issues: closes #...

Showcase (Optional)

test.mp4

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

@vercel
Copy link
Copy Markdown

vercel bot commented Aug 12, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Project Deployment Preview Comments Updated (UTC)
appkit-basic-html Ready Preview Comment Aug 12, 2025 9:13pm
appkit-demo Ready Preview Comment Aug 12, 2025 9:13pm
appkit-gallery Ready Preview Comment Aug 12, 2025 9:13pm
appkit-laboratory Ready Preview Comment Aug 12, 2025 9:13pm
10 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
appkit-basic-example ⬜️ Ignored Aug 12, 2025 9:13pm
appkit-basic-sign-client-example ⬜️ Ignored Aug 12, 2025 9:13pm
appkit-basic-up-example ⬜️ Ignored Aug 12, 2025 9:13pm
appkit-ethers5-bera ⬜️ Ignored Aug 12, 2025 9:13pm
appkit-nansen-demo ⬜️ Ignored Aug 12, 2025 9:13pm
appkit-vue-solana ⬜️ Ignored Aug 12, 2025 9:13pm
appkit-wagmi-cdn-example ⬜️ Ignored Aug 12, 2025 9:13pm
ethereum-provider-wagmi-example ⬜️ Ignored Aug 12, 2025 9:13pm
next-wagmi-solana-bitcoin-example ⬜️ Ignored Aug 12, 2025 9:13pm
vue-wagmi-example ⬜️ Ignored Aug 12, 2025 9:13pm

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Aug 12, 2025

🦋 Changeset detected

Latest commit: 4a2772c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 25 packages
Name Type
@reown/appkit-adapter-wagmi Patch
@reown/appkit-controllers Patch
@reown/appkit-scaffold-ui Patch
pay-test-exchange Patch
@reown/appkit-adapter-bitcoin Patch
@reown/appkit-adapter-ethers Patch
@reown/appkit-adapter-ethers5 Patch
@reown/appkit-adapter-solana Patch
@reown/appkit Patch
@reown/appkit-utils Patch
@reown/appkit-cdn Patch
@reown/appkit-cli Patch
@reown/appkit-codemod Patch
@reown/appkit-common Patch
@reown/appkit-core Patch
@reown/appkit-experimental Patch
@reown/appkit-pay Patch
@reown/appkit-polyfills Patch
@reown/appkit-siwe Patch
@reown/appkit-siwx Patch
@reown/appkit-testing Patch
@reown/appkit-ui Patch
@reown/appkit-universal-connector Patch
@reown/appkit-wallet Patch
@reown/appkit-wallet-button Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

cursor[bot]

This comment was marked as outdated.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 12, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 78.05% 32525 / 41669
🔵 Statements 78.05% 32525 / 41669
🔵 Functions 69.71% 2700 / 3873
🔵 Branches 84.88% 6918 / 8150
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/adapters/wagmi/src/client.ts 77.83% 65.8% 80.95% 77.83% 121-122, 127-128, 139-141, 143, 205-206, 246-249, 352-353, 367, 387-388, 463-464, 475-476, 511-512, 529-530, 544-561, 581-582, 595-600, 610-611, 615-616, 621-653, 672-678, 681-692, 701-702, 713-714, 735-737, 751-752, 765-766, 781-782, 831-832, 844-845, 853-854, 859-860, 867-868, 876-877, 882-883, 892-893, 901-902, 907-908, 914-936, 939-952
packages/controllers/src/controllers/ConnectionController.ts 83.57% 81.18% 54.02% 83.57% 166, 224-228, 231-235, 264-268, 276-277, 284-303, 310, 318, 322, 326, 330, 334, 338, 342, 346, 377-378, 381-382, 418, 422, 456-458, 469-470, 505-506, 516-517, 519-520, 528-529, 531-532, 551-552, 391
packages/scaffold-ui/src/views/w3m-connecting-wc-view/index.ts 76.47% 62.26% 66.66% 76.47% 55-56, 64, 73, 85-86, 95, 106-107, 136-138, 157-158, 172-173, 181-182, 193, 197-200, 205, 209, 226, 230-244
Generated in workflow #14224 for commit 4a2772c by the Vitest Coverage Report Action

@0xmkh 0xmkh added this pull request to the merge queue Aug 12, 2025
github-merge-queue bot pushed a commit that referenced this pull request Aug 12, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 12, 2025
@0xmkh 0xmkh added this pull request to the merge queue Aug 12, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 12, 2025
@0xmkh 0xmkh added this pull request to the merge queue Aug 12, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Aug 12, 2025
@0xmkh 0xmkh added this pull request to the merge queue Aug 12, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 12, 2025
@0xmkh 0xmkh added this pull request to the merge queue Aug 13, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 13, 2025
@0xmkh 0xmkh added this pull request to the merge queue Aug 13, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 13, 2025
@0xmkh 0xmkh added this pull request to the merge queue Aug 13, 2025
Merged via the queue into main with commit d4eeff9 Aug 13, 2025
58 of 60 checks passed
@0xmkh 0xmkh deleted the fix/wc-mobile-ux branch August 13, 2025 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants