Skip to content

feat: fund from exchange status and events#4822

Merged
tomiir merged 14 commits intomainfrom
feat/buy-status-fund-from-exchange
Aug 14, 2025
Merged

feat: fund from exchange status and events#4822
tomiir merged 14 commits intomainfrom
feat/buy-status-fund-from-exchange

Conversation

@tomiir
Copy link
Copy Markdown
Collaborator

@tomiir tomiir commented Aug 12, 2025

Description

  • Amends events to include a source parameter
  • Adds getBuyStatus to track payment status from the api
  • Routes screen on buy and prompts snackbar on success/failure

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Aug 12, 2025

⚠️ No Changeset found

Latest commit: 852dfe5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link
Copy Markdown

vercel bot commented Aug 12, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Project Deployment Preview Comments Updated (UTC)
appkit-basic-html Ready Preview Comment Aug 14, 2025 10:49am
appkit-demo Ready Preview Comment Aug 14, 2025 10:49am
appkit-gallery Ready Preview Comment Aug 14, 2025 10:49am
appkit-laboratory Ready Preview Comment Aug 14, 2025 10:49am
10 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
appkit-basic-example ⬜️ Ignored Aug 14, 2025 10:49am
appkit-basic-sign-client-example ⬜️ Ignored Aug 14, 2025 10:49am
appkit-basic-up-example ⬜️ Ignored Aug 14, 2025 10:49am
appkit-ethers5-bera ⬜️ Ignored Aug 14, 2025 10:49am
appkit-nansen-demo ⬜️ Ignored Aug 14, 2025 10:49am
appkit-vue-solana ⬜️ Ignored Aug 14, 2025 10:49am
appkit-wagmi-cdn-example ⬜️ Ignored Aug 14, 2025 10:49am
ethereum-provider-wagmi-example ⬜️ Ignored Aug 14, 2025 10:49am
next-wagmi-solana-bitcoin-example ⬜️ Ignored Aug 14, 2025 10:49am
vue-wagmi-example ⬜️ Ignored Aug 14, 2025 10:49am

@socket-security
Copy link
Copy Markdown

socket-security bot commented Aug 12, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Added@​sentry/​browser@​7.120.39910090100100

View full report

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 12, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 77.99% 32604 / 41802
🔵 Statements 77.99% 32604 / 41802
🔵 Functions 69.72% 2706 / 3881
🔵 Branches 84.83% 6935 / 8175
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/controllers/exports/index.ts 100% 100% 100% 100%
packages/controllers/src/controllers/ExchangeController.ts 88.65% 92.1% 69.23% 88.65% 97, 101, 114-115, 133, 145, 254, 309-328, 319
packages/controllers/src/utils/ExchangeUtil.ts 100% 92.85% 81.81% 100%
packages/pay/src/controllers/PayController.ts 87.71% 82.79% 85.71% 87.71% 102-103, 163-164, 198, 300-301, 304-306, 310-322, 332-333, 339-340, 345-346, 351-352, 355-356, 398-406, 424-425, 538-551, 560-561
packages/pay/src/utils/ApiUtil.ts 90.69% 88.88% 80% 90.69% 97-101
packages/scaffold-ui/src/views/w3m-deposit-from-exchange-view/index.ts 69.56% 71.42% 80% 69.56% 59-61, 64-65, 71-72, 146-152, 168-193
Generated in workflow #14263 for commit 852dfe5 by the Vitest Coverage Report Action

Comment on lines +254 to +257
// Wait 1 second before checking again
await new Promise(resolve => {
setTimeout(resolve, 5000)
})
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like it's 5 seconds?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lmk if it should be 5 or 1 seconds

exchangeId,
sessionId,
paymentId,
retries = 20
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is 20 retries too much?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants