Skip to content

fix: Fund from exchange redirect and popup#4832

Merged
tomiir merged 2 commits intomainfrom
fix/fund-from-exchange-redirect
Aug 14, 2025
Merged

fix: Fund from exchange redirect and popup#4832
tomiir merged 2 commits intomainfrom
fix/fund-from-exchange-redirect

Conversation

@tomiir
Copy link
Copy Markdown
Collaborator

@tomiir tomiir commented Aug 14, 2025

Description

  • Fixes issue where entering fund screen after starting a tx would redirect to Account inmediately
  • Opens popup instead of new tab

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Aug 14, 2025

⚠️ No Changeset found

Latest commit: 7f36cfa

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link
Copy Markdown

vercel bot commented Aug 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Project Deployment Preview Comments Updated (UTC)
appkit-basic-html Ready Preview Comment Aug 14, 2025 0:36am
appkit-demo Ready Preview Comment Aug 14, 2025 0:36am
appkit-gallery Ready Preview Comment Aug 14, 2025 0:36am
appkit-laboratory Ready Preview Comment Aug 14, 2025 0:36am
10 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
appkit-basic-example ⬜️ Ignored Aug 14, 2025 0:36am
appkit-basic-sign-client-example ⬜️ Ignored Aug 14, 2025 0:36am
appkit-basic-up-example ⬜️ Ignored Aug 14, 2025 0:36am
appkit-ethers5-bera ⬜️ Ignored Aug 14, 2025 0:36am
appkit-nansen-demo ⬜️ Ignored Aug 14, 2025 0:36am
appkit-vue-solana ⬜️ Ignored Aug 14, 2025 0:36am
appkit-wagmi-cdn-example ⬜️ Ignored Aug 14, 2025 0:36am
ethereum-provider-wagmi-example ⬜️ Ignored Aug 14, 2025 0:36am
next-wagmi-solana-bitcoin-example ⬜️ Ignored Aug 14, 2025 0:36am
vue-wagmi-example ⬜️ Ignored Aug 14, 2025 0:36am

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 14, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 78.01% 32624 / 41818
🔵 Statements 78.01% 32624 / 41818
🔵 Functions 69.72% 2706 / 3881
🔵 Branches 84.82% 6934 / 8174
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/controllers/src/controllers/ExchangeController.ts 88.84% 92.1% 69.23% 88.84% 97, 101, 114-115, 133, 145, 258, 313-332, 323
packages/scaffold-ui/src/views/w3m-deposit-from-exchange-view/index.ts 72.07% 71.42% 80% 72.07% 59-61, 64-65, 71-73, 147-153, 169-189
Generated in workflow #14272 for commit 7f36cfa by the Vitest Coverage Report Action

@tomiir tomiir merged commit 383a442 into main Aug 14, 2025
58 of 60 checks passed
@tomiir tomiir deleted the fix/fund-from-exchange-redirect branch August 14, 2025 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants