Skip to content

chore: fund wallet improvements#4841

Merged
0xmkh merged 7 commits intomainfrom
chore/improve-fund-from-exchange
Aug 19, 2025
Merged

chore: fund wallet improvements#4841
0xmkh merged 7 commits intomainfrom
chore/improve-fund-from-exchange

Conversation

@0xmkh
Copy link
Copy Markdown
Collaborator

@0xmkh 0xmkh commented Aug 15, 2025

Description

Added a few tweaks and improvements to the "Fund Wallet" flow

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-xxx
For GH issues: closes #...

Showcase (Optional)

If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Aug 15, 2025

🦋 Changeset detected

Latest commit: f6359f6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 25 packages
Name Type
@reown/appkit-controllers Patch
@reown/appkit-scaffold-ui Patch
pay-test-exchange Patch
@reown/appkit-adapter-bitcoin Patch
@reown/appkit-adapter-ethers Patch
@reown/appkit-adapter-ethers5 Patch
@reown/appkit-adapter-solana Patch
@reown/appkit-adapter-wagmi Patch
@reown/appkit Patch
@reown/appkit-utils Patch
@reown/appkit-cdn Patch
@reown/appkit-cli Patch
@reown/appkit-codemod Patch
@reown/appkit-common Patch
@reown/appkit-core Patch
@reown/appkit-experimental Patch
@reown/appkit-pay Patch
@reown/appkit-polyfills Patch
@reown/appkit-siwe Patch
@reown/appkit-siwx Patch
@reown/appkit-testing Patch
@reown/appkit-ui Patch
@reown/appkit-universal-connector Patch
@reown/appkit-wallet Patch
@reown/appkit-wallet-button Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link
Copy Markdown

vercel bot commented Aug 15, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
appkit-basic-html Ready Ready Preview Comment Aug 19, 2025 10:27am
appkit-demo Ready Ready Preview Comment Aug 19, 2025 10:27am
appkit-gallery Ready Ready Preview Comment Aug 19, 2025 10:27am
appkit-laboratory Ready Ready Preview Comment Aug 19, 2025 10:27am
10 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
appkit-basic-example Ignored Ignored Aug 19, 2025 10:27am
appkit-basic-sign-client-example Ignored Ignored Aug 19, 2025 10:27am
appkit-basic-up-example Ignored Ignored Aug 19, 2025 10:27am
appkit-ethers5-bera Ignored Ignored Aug 19, 2025 10:27am
appkit-nansen-demo Ignored Ignored Aug 19, 2025 10:27am
appkit-vue-solana Ignored Ignored Aug 19, 2025 10:27am
appkit-wagmi-cdn-example Ignored Ignored Aug 19, 2025 10:27am
ethereum-provider-wagmi-example Ignored Ignored Aug 19, 2025 10:27am
next-wagmi-solana-bitcoin-example Ignored Ignored Aug 19, 2025 10:27am
vue-wagmi-example Ignored Ignored Aug 19, 2025 10:27am

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 15, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 78.17% 34365 / 43960
🔵 Statements 78.17% 34365 / 43960
🔵 Functions 76.05% 3796 / 4991
🔵 Branches 86.76% 8135 / 9376
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/controllers/src/utils/ConstantsUtil.ts 100% 0% 100% 100%
packages/scaffold-ui/src/partials/w3m-account-default-widget/index.ts 81.92% 82.81% 65% 81.92% 73-74, 83, 87-89, 157, 163-164, 192, 215-216, 253, 261-262, 280, 287-288, 310, 314-315, 318-319, 322-323, 338, 342-352, 366-368, 390-392, 395-396, 349
packages/scaffold-ui/src/partials/w3m-account-wallet-features-widget/index.ts 72.61% 80.95% 70% 72.61% 70-77, 81, 92-94, 137, 152, 179, 182, 187-188, 215, 237, 259, 281-282, 284-285, 287-288, 295-299, 315, 319-320, 323-324, 327-347, 372-383, 343-380
packages/scaffold-ui/src/views/w3m-deposit-from-exchange-view/index.ts 76.03% 77.27% 80% 76.03% 59-61, 64-65, 71-73, 181-201
packages/scaffold-ui/src/views/w3m-fund-wallet-view/index.ts 81.01% 88.88% 70% 81.01% 34-36, 43-44, 52, 58-59, 78, 83-84, 102, 120, 132-133
Generated in workflow #14385 for commit f6359f6 by the Vitest Coverage Report Action

cursor[bot]

This comment was marked as outdated.

Copy link
Copy Markdown
Collaborator

@tomiir tomiir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests but looks good

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@vercel vercel bot temporarily deployed to Preview – appkit-demo August 19, 2025 10:12 Inactive
@0xmkh 0xmkh force-pushed the chore/improve-fund-from-exchange branch 2 times, most recently from f769920 to 20cf426 Compare August 19, 2025 10:16
@0xmkh 0xmkh force-pushed the chore/improve-fund-from-exchange branch from 20cf426 to beb08a7 Compare August 19, 2025 10:17
@vercel vercel bot temporarily deployed to Preview – appkit-demo August 19, 2025 10:17 Inactive
@vercel vercel bot temporarily deployed to Preview – appkit-demo August 19, 2025 10:21 Inactive
@0xmkh 0xmkh added this pull request to the merge queue Aug 19, 2025
Merged via the queue into main with commit aae952a Aug 19, 2025
59 of 60 checks passed
@0xmkh 0xmkh deleted the chore/improve-fund-from-exchange branch August 19, 2025 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants