Skip to content

chore: downgrade appkit demo and modify updateInternalDependencies#4865

Merged
lukaisailovic merged 3 commits intomainfrom
chore/downgrade-demo-reown-appkit
Aug 19, 2025
Merged

chore: downgrade appkit demo and modify updateInternalDependencies#4865
lukaisailovic merged 3 commits intomainfrom
chore/downgrade-demo-reown-appkit

Conversation

@0xmkh
Copy link
Copy Markdown
Collaborator

@0xmkh 0xmkh commented Aug 19, 2025

Description

Please include a brief summary of the change.

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-xxx
For GH issues: closes #...

Showcase (Optional)

If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

Copilot AI review requested due to automatic review settings August 19, 2025 08:25
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Aug 19, 2025

⚠️ No Changeset found

Latest commit: 3a294dc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link
Copy Markdown

vercel bot commented Aug 19, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
appkit-basic-html Ready Ready Preview Comment Aug 19, 2025 8:35am
appkit-demo Ready Ready Preview Comment Aug 19, 2025 8:35am
appkit-gallery Ready Ready Preview Comment Aug 19, 2025 8:35am
appkit-laboratory Ready Ready Preview Comment Aug 19, 2025 8:35am
10 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
appkit-basic-example Ignored Ignored Aug 19, 2025 8:35am
appkit-basic-sign-client-example Ignored Ignored Aug 19, 2025 8:35am
appkit-basic-up-example Ignored Ignored Aug 19, 2025 8:35am
appkit-ethers5-bera Ignored Ignored Aug 19, 2025 8:35am
appkit-nansen-demo Ignored Ignored Aug 19, 2025 8:35am
appkit-vue-solana Ignored Ignored Aug 19, 2025 8:35am
appkit-wagmi-cdn-example Ignored Ignored Aug 19, 2025 8:35am
ethereum-provider-wagmi-example Ignored Ignored Aug 19, 2025 8:35am
next-wagmi-solana-bitcoin-example Ignored Ignored Aug 19, 2025 8:35am
vue-wagmi-example Ignored Ignored Aug 19, 2025 8:35am

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR downgrades the AppKit demo dependencies from version 1.7.19 to 1.7.18 and removes the updateInternalDependencies configuration from the changeset config. This appears to be a maintenance change to align dependency versions and simplify the changeset configuration.

  • Downgrade all @reown/appkit-* packages from 1.7.19 to 1.7.18
  • Remove updateInternalDependencies setting from changeset configuration

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
apps/demo/package.json Downgrades all @reown/appkit-* dependencies from 1.7.19 to 1.7.18
.changeset/config.json Removes the updateInternalDependencies patch configuration
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@socket-security
Copy link
Copy Markdown

socket-security bot commented Aug 19, 2025

@0xmkh 0xmkh changed the title chore: downgrade appkit demo and remove updateInternalDependencies chore: downgrade appkit demo and modify updateInternalDependencies Aug 19, 2025
@lukaisailovic lukaisailovic merged commit 8525f23 into main Aug 19, 2025
20 of 24 checks passed
@lukaisailovic lukaisailovic deleted the chore/downgrade-demo-reown-appkit branch August 19, 2025 08:28
"access": "public",
"baseBranch": "main",
"updateInternalDependencies": "patch",
"updateInternalDependencies": "minor",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: PR Title Mismatch: Incorrect Version Bump Description

The PR title "remove updateInternalDependencies" doesn't match the change, which modifies the value from "patch" to "minor". This means internal dependencies will now receive minor version bumps instead of patch bumps during publishing.

Fix in Cursor Fix in Web

@github-actions
Copy link
Copy Markdown
Contributor

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 78.13% 34323 / 43926
🔵 Statements 78.13% 34323 / 43926
🔵 Functions 75.95% 3791 / 4991
🔵 Branches 86.71% 8110 / 9352
File CoverageNo changed files found.
Generated in workflow #14369 for commit 3a294dc by the Vitest Coverage Report Action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants