fix: api controller wallet filtering on mobile#4872
Merged
Conversation
🦋 Changeset detectedLatest commit: 0989938 The changes in this PR will be included in the next version bump. This PR includes changesets to release 25 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
10 Skipped Deployments
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes wallet filtering logic in the ApiController to properly handle webapp wallets on mobile devices, addressing a bug where webapp-only wallets were being incorrectly filtered out on mobile platforms.
- Updated mobile wallet filtering to include wallets with
webapp_linkin addition tomobile_link - Simplified custom deeplink wallet logic to include all custom deeplink wallets regardless of chain
- Updated test cases to verify the new filtering behavior and provide comprehensive coverage
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/controllers/src/controllers/ApiController.ts | Modified _filterWalletsByPlatform to include webapp wallets on mobile and simplified custom deeplink wallet handling |
| packages/controllers/tests/controllers/ApiController.test.ts | Added comprehensive test cases for the new filtering logic and updated existing tests |
| packages/ui/tests/UiHelperUtil.test.ts | Added timezone specification to date test cases for consistency |
| .changeset/giant-lines-lie.md | Added changeset documentation for the bug fix |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Contributor
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||
tomiir
approved these changes
Aug 19, 2025
tomiir
requested changes
Aug 19, 2025
Collaborator
tomiir
left a comment
tomiir
left a comment
There was a problem hiding this comment.
This will filter out special cases. We need to find a different solution
arein
approved these changes
Aug 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix filtering of wallets on ApiController to allow webapp wallets in mobile.
Type of change
Associated Issues
For Linear issues: Closes DAS-736
Checklist