Skip to content

chore: update top padding on input page#4874

Merged
enesozturk merged 1 commit intomainfrom
chore/account-name-input-paddings
Aug 19, 2025
Merged

chore: update top padding on input page#4874
enesozturk merged 1 commit intomainfrom
chore/account-name-input-paddings

Conversation

@enesozturk
Copy link
Copy Markdown
Contributor

Description

Updates top padding on account name select screen where input's border getting cut by header

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-xxx
For GH issues: closes #...

Showcase (Optional)

Before
Screenshot 2025-08-19 at 16 34 15

After
Screenshot 2025-08-19 at 16 34 43

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

Copilot AI review requested due to automatic review settings August 19, 2025 13:34
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Aug 19, 2025

⚠️ No Changeset found

Latest commit: cfe9952

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a visual issue where the input border was being cut off by the header on the account name select screen by adjusting the top padding.

  • Updated top padding from '0' to '1' to provide proper spacing between header and input field

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@vercel
Copy link
Copy Markdown

vercel bot commented Aug 19, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
appkit-basic-html Ready Ready Preview Comment Aug 19, 2025 1:46pm
appkit-gallery Ready Ready Preview Comment Aug 19, 2025 1:46pm
appkit-laboratory Ready Ready Preview Comment Aug 19, 2025 1:46pm
11 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
appkit-basic-example Ignored Ignored Aug 19, 2025 1:46pm
appkit-basic-sign-client-example Ignored Ignored Aug 19, 2025 1:46pm
appkit-basic-up-example Ignored Ignored Aug 19, 2025 1:46pm
appkit-ethers5-bera Ignored Ignored Aug 19, 2025 1:46pm
appkit-nansen-demo Ignored Ignored Aug 19, 2025 1:46pm
appkit-vue-solana Ignored Ignored Aug 19, 2025 1:46pm
appkit-wagmi-cdn-example Ignored Ignored Aug 19, 2025 1:46pm
ethereum-provider-wagmi-example Ignored Ignored Aug 19, 2025 1:46pm
next-wagmi-solana-bitcoin-example Ignored Ignored Aug 19, 2025 1:46pm
vue-wagmi-example Ignored Ignored Aug 19, 2025 1:46pm
appkit-demo Skipped Skipped Aug 19, 2025 1:46pm

@github-actions
Copy link
Copy Markdown
Contributor

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 78.17% 34365 / 43960
🔵 Statements 78.17% 34365 / 43960
🔵 Functions 76.05% 3796 / 4991
🔵 Branches 86.73% 8132 / 9376
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/scaffold-ui/src/views/w3m-register-account-name-view/index.ts 21.25% 100% 0% 21.25% 51-66, 70-71, 74-77, 81-102, 106-130, 145-148, 152-155, 158-175, 178-191, 194-233, 236-240
Generated in workflow #14403 for commit cfe9952 by the Vitest Coverage Report Action

@enesozturk enesozturk added this pull request to the merge queue Aug 19, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 19, 2025
@enesozturk enesozturk added this pull request to the merge queue Aug 19, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 19, 2025
@enesozturk enesozturk added this pull request to the merge queue Aug 19, 2025
Merged via the queue into main with commit 00d8dca Aug 19, 2025
41 checks passed
@enesozturk enesozturk deleted the chore/account-name-input-paddings branch August 19, 2025 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants