fix: allow sending spl solana tokens in send flow#4877
Merged
Conversation
🦋 Changeset detectedLatest commit: d72b81a The changes in this PR will be included in the next version bump. This PR includes changesets to release 25 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
11 Skipped Deployments
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue preventing users from sending SPL (Solana Program Library) tokens through the send flow. The fix extracts the token mint address from the CAIP address format when sending SPL tokens.
- Adds logic to extract the SPL token mint address from CAIP addresses for Solana token transfers
- Includes comprehensive test coverage for both native SOL and SPL token sending scenarios
- Adds a constant for the native SOL token address
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/controllers/src/controllers/SendController.ts | Implements token mint extraction logic for SPL token transfers |
| packages/controllers/tests/controllers/SendController.test.ts | Adds comprehensive test coverage for the new SPL token sending functionality |
| packages/common/src/utils/ConstantsUtil.ts | Adds constant for native SOL token address |
| .changeset/seven-rabbits-behave.md | Documents the bug fix in changeset for release notes |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
svenvoskamp
approved these changes
Aug 19, 2025
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed an issue where users could not send SPL solana tokens through the send flow
Type of change
Associated Issues
For Linear issues: Closes APKT-3625
Showcase (Optional)
Checklist