fix: mobile popup blocking and improve fund wallet ux#4880
Merged
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
11 Skipped Deployments
|
0xmkh
changed the title
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes mobile popup blocking issues and improves the fund wallet user experience by updating the popup creation mechanism and adding real-time balance updates.
- Replaced
CoreHelperUtil.openHrefwithCoreHelperUtil.returnOpenHrefto avoid mobile popup blocking - Added automatic balance updates after successful deposits
- Updated API URL construction to include SDK metadata in query parameters
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/scaffold-ui/src/views/w3m-deposit-from-exchange-view/index.ts | Added balance update after successful deposit completion |
| packages/controllers/src/controllers/ExchangeController.ts | Updated popup creation to use returnOpenHref method to avoid blocking |
| packages/controllers/src/controllers/ConnectionController.ts | Added updateBalance method to trigger balance refresh |
| packages/controllers/src/utils/ExchangeUtil.ts | Refactored URL construction to use URL API and moved SDK parameters to query string |
| packages/controllers/tests/utils/ExchangeUtil.test.ts | Updated tests to include SDK metadata in URL expectations |
| packages/controllers/tests/controllers/ExchangeController.test.ts | Updated test to use new popup creation mechanism |
| .changeset/violet-rivers-pump.md | Added changeset documentation for the fix |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Contributor
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||
tomiir
reviewed
Aug 20, 2025
tomiir
reviewed
Aug 20, 2025
tomiir
reviewed
Aug 20, 2025
tomiir
approved these changes
Aug 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed an issue where fund wallet popup was blocked on mobile, updated balance realtime and improved ux
Type of change
Associated Issues
For Linear issues: Closes APKT-3610,APKT-3613,APKT-3607,APKIT-3611
Checklist