fix: include correct user address in bitcoin walletconnect signing request#4886
Merged
fix: include correct user address in bitcoin walletconnect signing request#4886
Conversation
🦋 Changeset detectedLatest commit: 803b931 The changes in this PR will be included in the next version bump. This PR includes changesets to release 25 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
10 Skipped Deployments
|
…quest fix: include correct user address in bitcoin walletconnect signing request
0xmkh
force-pushed
the
fix/wc-btc-signing
branch
from
309bae0 to
f015567
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
Fixes an issue where Bitcoin WalletConnect signing requests were not using the correct user address. The fix ensures that the Bitcoin connector retrieves and matches the correct account from the user's active session.
- Updates the
getAccountmethod to useAccountController.getCaipAddressto get the correct user address - Adds logic to find the matching account in the session namespaces using case-insensitive comparison
- Updates tests to mock the account controller and reflect the new error message
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/adapters/bitcoin/src/connectors/BitcoinWalletConnectConnector.ts | Modified getAccount method to use AccountController and find matching account with proper address comparison |
| packages/adapters/bitcoin/tests/utils/WalletConnectProvider.test.ts | Added AccountController import, mocked getCaipAddress method, and updated error message assertion |
| .changeset/ten-lights-watch.md | Added changeset documentation for the bug fix |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
packages/adapters/bitcoin/src/connectors/BitcoinWalletConnectConnector.ts
Outdated
Show resolved
Hide resolved
tomiir
reviewed
Aug 21, 2025
Collaborator
tomiir
left a comment
tomiir
left a comment
There was a problem hiding this comment.
Can we add a test where we have addresses for both networks and the correct one is selected?
Contributor
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||
svenvoskamp
approved these changes
Aug 21, 2025
tomiir
approved these changes
Aug 21, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed an issue where bitcoin walletconnect signing requests did not include the correct user address
Type of change
Associated Issues
For Linear issues: Closes APKT-3637
Checklist