feat: connect all namespaces for auth connector#4888
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
10 Skipped Deployments
|
…t-of-different-chain-2
There was a problem hiding this comment.
Pull Request Overview
This PR extends the Auth connector functionality to support multi-namespace connections, ensuring users connecting via auth providers (email/social) are automatically connected to all supported namespaces simultaneously, similar to WalletConnect behavior.
Key changes:
- Refactored
connectExternalmethod to handle multi-namespace auth connections - Added helper utilities for namespace management and chain ID parsing
- Enhanced account synchronization logic for non-active namespaces
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
packages/controllers/exports/index.ts |
Added wildcard export for ConnectionController types |
packages/appkit/src/client/appkit.ts |
Updated auth provider connection logic to use proper namespace detection |
packages/appkit/src/client/appkit-base-client.ts |
Major refactoring of connection logic with new multi-namespace support |
packages/appkit-utils/src/HelpersUtil.ts |
Added utilities for chain namespace parsing and auth namespace filtering |
packages/appkit-utils/tests/HelperUtil.test.ts |
Added comprehensive tests for new helper functions |
apps/laboratory/tests/shared/validators/ModalValidator.ts |
Enhanced test validation for namespace-specific balance checking |
apps/laboratory/tests/shared/utils/project.ts |
Added new test configuration for multichain email tests |
apps/laboratory/tests/multichain/multichain-all.spec.ts |
Updated test assertions for namespace-specific balance validation |
apps/laboratory/tests/multichain/multichain-all-email.spec.ts |
New comprehensive e2e tests for multi-namespace email auth |
apps/laboratory/tests/multichain-extension.spec.ts |
Updated extension tests to handle multi-namespace scenarios |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
…t-of-different-chain-2
tomiir
left a comment
tomiir
left a comment
There was a problem hiding this comment.
the appkit-base-client chagnes are code formatting / nicer code but no functional changes right?
tomiir
deleted the
enes/apkt-3045-multichain-the-embedded-wallet-of-different-chain-2
branch
Description
Updates connectExternal method to handle Auth connections to be connected for all namespaces. When user connected with auth provider, we should sync all supported namespace's accounts to AppKit, like WC.
In this PR, iterates remaining (non active) Auth supported namespaces to call .connect and syncs account info for that namespace. Makes relevant changes to AppKit class and some controllers and adds e2e tests
Type of change
Associated Issues
For Linear issues: Closes APKT-xxx
For GH issues: closes #...
Showcase (Optional)
If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.
Checklist