Skip to content

fix: correct count calculations for mobile environments in all-wallets-list#4917

Merged
svenvoskamp merged 54 commits intomainfrom
APKT-3450
Aug 29, 2025
Merged

fix: correct count calculations for mobile environments in all-wallets-list#4917
svenvoskamp merged 54 commits intomainfrom
APKT-3450

Conversation

@svenvoskamp
Copy link
Copy Markdown
Contributor

Description

We had an issue on mobile environments where there would be an incorrect amount of loading skeletons in the all-wallets-list. This was due to an incorrect calculation of our count value. The count value did not respect the filtered out wallets for mobile environments. This PR fixes this and calculates the correct count.

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-3450
For GH issues: closes #...

Showcase (Optional)

If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

svenvoskamp added 30 commits May 6, 2025 09:33
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Fixes incorrect count calculations for mobile environments in the all-wallets-list component that resulted in displaying the wrong number of loading skeletons.

  • Tracks the number of wallets filtered out for mobile environments in the ApiController state
  • Updates pagination loader logic to account for filtered wallets when calculating remaining items
  • Adds comprehensive test coverage for mobile filtering scenarios

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
packages/scaffold-ui/src/partials/w3m-all-wallets-list/index.ts Updates pagination loader to use corrected count that accounts for mobile-filtered wallets
packages/controllers/src/controllers/ApiController.ts Adds tracking of mobile filtered wallets count and updates filtering method to return both filtered wallets and count
packages/controllers/tests/controllers/ApiController.test.ts Updates existing tests to use new return format and adds comprehensive test coverage for mobile filtering scenarios
packages/appkit/exports/constants.ts Updates package version from 1.7.20 to 1.8.0
.changeset/fluffy-streets-smoke.md Adds changeset entry documenting the bug fix

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

cursor[bot]

This comment was marked as outdated.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 29, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 78.3% 34800 / 44440
🔵 Statements 78.3% 34800 / 44440
🔵 Functions 76.19% 3834 / 5032
🔵 Branches 86.67% 8212 / 9474
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/controllers/src/controllers/ApiController.ts 94.59% 94.02% 85.45% 94.59% 100-101, 156, 171, 227, 234-235, 431-439, 466, 480, 484, 488
packages/scaffold-ui/src/partials/w3m-all-wallets-list/index.ts 90.24% 86.2% 92.3% 90.24% 76, 103, 110, 131, 145-146, 163-168
Generated in workflow #14626 for commit 6cf68f4 by the Vitest Coverage Report Action

cursor[bot]

This comment was marked as outdated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants