fix: correct count calculations for mobile environments in all-wallets-list#4917
Merged
svenvoskamp merged 54 commits intomainfrom Aug 29, 2025
Merged
fix: correct count calculations for mobile environments in all-wallets-list#4917svenvoskamp merged 54 commits intomainfrom
all-wallets-list#4917svenvoskamp merged 54 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Fixes incorrect count calculations for mobile environments in the all-wallets-list component that resulted in displaying the wrong number of loading skeletons.
- Tracks the number of wallets filtered out for mobile environments in the ApiController state
- Updates pagination loader logic to account for filtered wallets when calculating remaining items
- Adds comprehensive test coverage for mobile filtering scenarios
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/scaffold-ui/src/partials/w3m-all-wallets-list/index.ts | Updates pagination loader to use corrected count that accounts for mobile-filtered wallets |
| packages/controllers/src/controllers/ApiController.ts | Adds tracking of mobile filtered wallets count and updates filtering method to return both filtered wallets and count |
| packages/controllers/tests/controllers/ApiController.test.ts | Updates existing tests to use new return format and adds comprehensive test coverage for mobile filtering scenarios |
| packages/appkit/exports/constants.ts | Updates package version from 1.7.20 to 1.8.0 |
| .changeset/fluffy-streets-smoke.md | Adds changeset entry documenting the bug fix |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Contributor
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||
0xmkh
approved these changes
Aug 29, 2025
This was referenced Aug 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We had an issue on mobile environments where there would be an incorrect amount of loading skeletons in the
all-wallets-list. This was due to an incorrect calculation of ourcountvalue. The count value did not respect the filtered out wallets for mobile environments. This PR fixes this and calculates the correct count.Type of change
Associated Issues
For Linear issues: Closes APKT-3450
For GH issues: closes #...
Showcase (Optional)
If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.
Checklist