chore: prevent calling SELECT_WALLET event for basic#4921
Merged
enesozturk merged 4 commits intomainfrom Sep 1, 2025
Merged
Conversation
🦋 Changeset detectedLatest commit: 524e2af The changes in this PR will be included in the next version bump. This PR includes changesets to release 24 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
10 Skipped Deployments
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR prevents the SELECT_WALLET event from being triggered in the basic WalletConnect connection flow. The change addresses a scenario where ConnectingWcBasic renders ConnectingWc directly without manual wallet selection, making the SELECT_WALLET event inappropriate.
- Adds a
basicproperty to control when theSELECT_WALLETevent should be triggered - Conditionally prevents the event in the QR code component when in basic mode
- Updates the package version to 1.8.0
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/scaffold-ui/src/views/w3m-connecting-wc-view/index.ts | Adds basic property and passes it to QR code component |
| packages/scaffold-ui/src/views/w3m-connecting-wc-basic-view/index.ts | Sets basic=true when rendering the connecting view |
| packages/scaffold-ui/src/partials/w3m-connecting-wc-qrcode/index.ts | Implements conditional SELECT_WALLET event logic based on basic property |
| packages/appkit/exports/constants.ts | Bumps package version to 1.8.0 |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
packages/scaffold-ui/src/partials/w3m-connecting-wc-qrcode/index.ts
Outdated
Show resolved
Hide resolved
enesozturk
changed the title
Contributor
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||
svenvoskamp
approved these changes
Aug 29, 2025
0xmkh
approved these changes
Aug 29, 2025
…m-select_wallet-to-open_qr
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
enesozturk
deleted the
enes/apkt-3606-update-appkit-core-events-from-select_wallet-to-open_qr
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We have
ConnectingWcBasicview where we renderConnectingWcview, which callsSELECT_WALLETevent on it's contructor. But theConnectingWcBasiccase is a bit different that we show this page directly instead they select WC manually. So in this case we shouldn't triggerSELECT_WALLETevent.Type of change
Associated Issues
For Linear issues: Closes APKT-xxx
For GH issues: closes #...
Showcase (Optional)
If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.
Checklist