Skip to content

feat: QR scan via main camera#4936

Merged
tomiir merged 10 commits intomainfrom
feat/main-camera-qr-scan
Sep 15, 2025
Merged

feat: QR scan via main camera#4936
tomiir merged 10 commits intomainfrom
feat/main-camera-qr-scan

Conversation

@ganchoradkov
Copy link
Copy Markdown
Member

@ganchoradkov ganchoradkov commented Sep 1, 2025

Description

This PR enhances QR code functionality to support scanning via the main camera by automatically including mobile deep links in the QR code URI when available.

  • Imports CoreHelperUtil to format native URLs with mobile deep links
  • Modifies QR code generation to include mobile links when wallet supports them
  • Updates the QR code component to use the enhanced URI that prompts wallet opening when scanned

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

https://linear.app/reown/issue/APKT-3690/walletconnect-launcher

Showcase (Optional)

If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

Copilot AI review requested due to automatic review settings September 1, 2025 14:05
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Sep 1, 2025

🦋 Changeset detected

Latest commit: 35632fe

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 25 packages
Name Type
@reown/appkit-scaffold-ui Patch
pay-test-exchange Patch
@reown/appkit-adapter-bitcoin Patch
@reown/appkit-adapter-ethers Patch
@reown/appkit-adapter-ethers5 Patch
@reown/appkit-adapter-solana Patch
@reown/appkit-adapter-wagmi Patch
@reown/appkit Patch
@reown/appkit-utils Patch
@reown/appkit-cdn Patch
@reown/appkit-cli Patch
@reown/appkit-codemod Patch
@reown/appkit-common Patch
@reown/appkit-controllers Patch
@reown/appkit-core Patch
@reown/appkit-experimental Patch
@reown/appkit-pay Patch
@reown/appkit-polyfills Patch
@reown/appkit-siwe Patch
@reown/appkit-siwx Patch
@reown/appkit-testing Patch
@reown/appkit-ui Patch
@reown/appkit-universal-connector Patch
@reown/appkit-wallet Patch
@reown/appkit-wallet-button Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link
Copy Markdown

vercel bot commented Sep 1, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
appkit-basic-html Ready Ready Preview Comment Sep 15, 2025 10:34am
appkit-demo Ready Ready Preview Comment Sep 15, 2025 10:34am
appkit-gallery Ready Ready Preview Comment Sep 15, 2025 10:34am
appkit-laboratory Ready Ready Preview Comment Sep 15, 2025 10:34am
10 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
appkit-basic-example Ignored Ignored Sep 15, 2025 10:34am
appkit-basic-sign-client-example Ignored Ignored Sep 15, 2025 10:34am
appkit-basic-up-example Ignored Ignored Sep 15, 2025 10:34am
appkit-ethers5-bera Ignored Ignored Sep 15, 2025 10:34am
appkit-nansen-demo Ignored Ignored Sep 15, 2025 10:34am
appkit-vue-solana Ignored Ignored Sep 15, 2025 10:34am
appkit-wagmi-cdn-example Ignored Ignored Sep 15, 2025 10:34am
ethereum-provider-wagmi-example Ignored Ignored Sep 15, 2025 10:34am
next-wagmi-solana-bitcoin-example Ignored Ignored Sep 15, 2025 10:34am
vue-wagmi-example Ignored Ignored Sep 15, 2025 10:34am

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances QR code functionality to support scanning via the main camera by automatically including mobile deep links in the QR code URI when available.

  • Imports CoreHelperUtil to format native URLs with mobile deep links
  • Modifies QR code generation to include mobile links when wallet supports them
  • Updates the QR code component to use the enhanced URI that prompts wallet opening when scanned

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 1, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 78.19% 35535 / 45445
🔵 Statements 78.19% 35535 / 45445
🔵 Functions 75.92% 3897 / 5133
🔵 Branches 86.54% 8424 / 9734
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/controllers/src/utils/CoreHelperUtil.ts 75.46% 84.76% 65.11% 75.46% 30, 34, 59-60, 76, 80, 87-88, 103-104, 115, 138-139, 176, 192-193, 211-217, 247-248, 260-268, 315-320, 328, 344, 352, 354, 356-357, 367-372, 376-379, 389, 394, 399, 460, 464-468, 477-480, 483-485, 489-504, 507-532, 421-439
packages/scaffold-ui/src/partials/w3m-connecting-wc-qrcode/index.ts 91.02% 95.65% 66.66% 91.02% 54-57, 75, 116, 131
Generated in workflow #15064 for commit 35632fe by the Vitest Coverage Report Action

cursor[bot]

This comment was marked as outdated.

Copy link
Copy Markdown
Collaborator

@tomiir tomiir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need a test for this?
Also what happens if redirect is undefined?

cursor[bot]

This comment was marked as outdated.

@ganchoradkov ganchoradkov requested a review from tomiir September 15, 2025 10:24
@ganchoradkov ganchoradkov added this pull request to the merge queue Sep 15, 2025
@tomiir tomiir removed this pull request from the merge queue due to a manual request Sep 15, 2025
@tomiir tomiir merged commit 0bf1921 into main Sep 15, 2025
42 checks passed
@tomiir tomiir deleted the feat/main-camera-qr-scan branch September 15, 2025 10:59
@github-actions github-actions bot locked and limited conversation to collaborators Sep 15, 2025
@0xmkh 0xmkh restored the feat/main-camera-qr-scan branch October 17, 2025 08:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants