Skip to content

chore: include insufficient funds fee error message#4939

Merged
lukaisailovic merged 2 commits intomainfrom
chore/insufficient-fee
Sep 1, 2025
Merged

chore: include insufficient funds fee error message#4939
lukaisailovic merged 2 commits intomainfrom
chore/insufficient-fee

Conversation

@0xmkh
Copy link
Copy Markdown
Collaborator

@0xmkh 0xmkh commented Sep 1, 2025

Description

Please include a brief summary of the change.

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-xxx
For GH issues: closes #...

Showcase (Optional)

If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

Copilot AI review requested due to automatic review settings September 1, 2025 16:59
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Sep 1, 2025

⚠️ No Changeset found

Latest commit: 8f78cc7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link
Copy Markdown

vercel bot commented Sep 1, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
appkit-basic-html Ready Ready Preview Comment Sep 1, 2025 5:06pm
appkit-demo Ready Ready Preview Comment Sep 1, 2025 5:06pm
appkit-gallery Ready Ready Preview Comment Sep 1, 2025 5:06pm
appkit-laboratory Ready Ready Preview Comment Sep 1, 2025 5:06pm
10 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
appkit-basic-example Ignored Ignored Sep 1, 2025 5:06pm
appkit-basic-sign-client-example Ignored Ignored Sep 1, 2025 5:06pm
appkit-basic-up-example Ignored Ignored Sep 1, 2025 5:06pm
appkit-ethers5-bera Ignored Ignored Sep 1, 2025 5:06pm
appkit-nansen-demo Ignored Ignored Sep 1, 2025 5:06pm
appkit-vue-solana Ignored Ignored Sep 1, 2025 5:06pm
appkit-wagmi-cdn-example Ignored Ignored Sep 1, 2025 5:06pm
ethereum-provider-wagmi-example Ignored Ignored Sep 1, 2025 5:06pm
next-wagmi-solana-bitcoin-example Ignored Ignored Sep 1, 2025 5:06pm
vue-wagmi-example Ignored Ignored Sep 1, 2025 5:06pm

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new error mapping to handle "Insufficient funds for fee" transaction simulation errors in the Solana adapter. It ensures users receive a clear, user-friendly error message when they don't have enough SOL to cover transaction fees.

  • Adds a new error pattern mapping for insufficient funds scenarios
  • Provides consistent error messaging across different insufficient funds cases

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 1, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 78.33% 34864 / 44504
🔵 Statements 78.33% 34864 / 44504
🔵 Functions 76.09% 3838 / 5044
🔵 Branches 86.68% 8233 / 9498
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/adapters/solana/src/client.ts 65.27% 75.71% 38.88% 65.27% 92-99, 103-104, 132-135, 138-139, 142-143, 146-147, 150-153, 156-164, 171-172, 182-202, 205-258, 261-262, 265-266, 274-275, 280-287, 307-320, 343-346, 370-371, 381-382, 401-402, 409-410, 434-435, 439-440, 443-444, 481-485, 509-510, 533-539
Generated in workflow #14693 for commit 8f78cc7 by the Vitest Coverage Report Action

@0xmkh 0xmkh added this pull request to the merge queue Sep 1, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 1, 2025
@0xmkh 0xmkh added this pull request to the merge queue Sep 1, 2025
@lukaisailovic lukaisailovic removed this pull request from the merge queue due to a manual request Sep 1, 2025
@lukaisailovic lukaisailovic merged commit 6fa29f5 into main Sep 1, 2025
53 of 60 checks passed
@lukaisailovic lukaisailovic deleted the chore/insufficient-fee branch September 1, 2025 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants