fix: fund from exchange not working at first try#4941
Merged
Conversation
🦋 Changeset detectedLatest commit: f31b022 The changes in this PR will be included in the next version bump. This PR includes changesets to release 25 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
10 Skipped Deployments
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where funding from the exchange failed on the first attempt due to a preset dollar amount of $10. The fix changes the default amount from 10 to 0 in the ExchangeController's initial state.
- Changed default amount from 10 to 0 in ExchangeController state
- Added test coverage to verify the default state
- Exported DEFAULT_STATE constant for testing purposes
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| ExchangeController.ts | Changed default amount from 10 to 0 and exported DEFAULT_STATE constant |
| ExchangeController.test.ts | Added test to verify default state and imported DEFAULT_STATE |
| tall-peaches-clap.md | Added changeset documenting the bug fix |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
tomiir
reviewed
Sep 2, 2025
0xmkh
changed the title
Contributor
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||
tomiir
approved these changes
Sep 2, 2025
Collaborator
tomiir
left a comment
tomiir
left a comment
There was a problem hiding this comment.
adapt the changeset and looks good!
0xmkh
force-pushed
the
fix/fund-from-exchange-first-try
branch
from
f0e92d1 to
7765800
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed an issue where funding from the exchange had a preset dollar amount causing it to fail on the first attempt
Type of change
Associated Issues
For Linear issues: Closes APKT-xxx
For GH issues: closes #...
Showcase (Optional)
Checklist