Conversation
🦋 Changeset detectedLatest commit: b14a966 The changes in this PR will be included in the next version bump. This PR includes changesets to release 24 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
10 Skipped Deployments
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where Bitcoin account publicKey is not properly set during adapter reconnection. The fix addresses duplicate synchronization calls and missing publicKey retrieval.
- Removes duplicate call to
syncExistingConnection()during initialization to prevent redundant connection syncing - Refactors
syncAdapterConnections()to use a newsyncAdapterConnection()method for cleaner code - Adds debug logging to investigate account data during synchronization
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/appkit/src/client/appkit-base-client.ts | Removes duplicate sync call and refactors adapter connection logic with debug logging |
| packages/appkit/exports/constants.ts | Updates package version from 1.8.0 to 1.8.2 |
| apps/laboratory/src/layout/LayoutHeader.tsx | Simplifies URL display logic by removing pathname dependency |
| .changeset/orange-parents-stay.md | Adds changeset entry documenting the Bitcoin publicKey fix |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Contributor
…e functions to helpers
enesozturk
force-pushed
the
enes/apkt-3693-bob-when-refrefreshing-page-bitcoin-connector-reconnects-but
branch
from
434b7c0 to
849b1c6
Compare
enesozturk
commented
Sep 3, 2025
enesozturk
commented
Sep 3, 2025
enesozturk
commented
Sep 3, 2025
enesozturk
commented
Sep 3, 2025
…itcoin-connector-reconnects-but
…itcoin-connector-reconnects-but
0xmkh
reviewed
Sep 3, 2025
0xmkh
reviewed
Sep 3, 2025
0xmkh
reviewed
Sep 3, 2025
Contributor
0xmkh
approved these changes
Sep 3, 2025
tomiir
deleted the
enes/apkt-3693-bob-when-refrefreshing-page-bitcoin-connector-reconnects-but
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When reconnecting the adapter connections, the publicKey field of the Bitcoin account doesn't get set as expected.
Two problem identified on the base class'
initializemethod:await this.syncExistingConnection()andawait this.syncAdapterConnections()and this causes getting the connection two times which is unnecessary.await this.syncExistingConnection(), the publicKey returns under allAccounts objects, butawait this.syncAdapterConnections()doesn't return thepublicKeyas expected. So when this function run aftersyncExistingConnection, the publicKey lost.Type of change
Associated Issues
For Linear issues: Closes APKT-xxx
For GH issues: closes #...
Showcase (Optional)
If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.
Checklist