Merged
Conversation
🦋 Changeset detectedLatest commit: 9f3f3af The changes in this PR will be included in the next version bump. This PR includes changesets to release 24 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
10 Skipped Deployments
|
ganchoradkov
commented
Sep 3, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements pulse events batching to improve analytics performance by accumulating events and submitting them in batches via navigator.sendBeacon. The implementation automatically submits events when the page becomes hidden or when a size limit is reached.
Key changes:
- Replaces immediate event submission with batching mechanism
- Adds automatic submission on visibility change events
- Implements size-based auto-submission (45KB limit)
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| EventsController.test.ts | Comprehensive test coverage for batching functionality and visibility change handling |
| TypeUtil.ts | Adds PendingEvent type definition for batched events |
| FetchUtil.ts | Adds sendBeacon method for batch submission |
| EventsController.ts | Core implementation of events batching and submission logic |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
enesozturk
approved these changes
Sep 3, 2025
Contributor
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||
enesozturk
reviewed
Sep 3, 2025
tomiir
reviewed
Sep 3, 2025
tomiir
approved these changes
Sep 3, 2025
lukaisailovic
approved these changes
Sep 3, 2025
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements pulse events batching to improve analytics performance by accumulating events and submitting them in batches via navigator.sendBeacon. The implementation automatically submits events when the page becomes hidden or when a size limit is reached.
Key changes:
https://www.notion.so/walletconnect/Reducing-pulse-api-calls-from-AppKit-2613a661771e8050b338c2b9c83d9b54#2613a661771e8050b338c2b9c83d9b54
Type of change
Associated Issues
https://linear.app/reown/issue/APKT-3720/appkit-pulse-events-batching
Checklist