Skip to content

chore: replace "deposit from an exchange" to "deposit from exchange" in header#4957

Merged
tomiir merged 3 commits intomainfrom
chore/rename-exchange-header
Sep 4, 2025
Merged

chore: replace "deposit from an exchange" to "deposit from exchange" in header#4957
tomiir merged 3 commits intomainfrom
chore/rename-exchange-header

Conversation

@0xmkh
Copy link
Copy Markdown
Collaborator

@0xmkh 0xmkh commented Sep 4, 2025

Description

Replace "deposit from an exchange" to "deposit from exchange"

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-xxx
For GH issues: closes #...

Showcase (Optional)

If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

Copilot AI review requested due to automatic review settings September 4, 2025 08:36
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Sep 4, 2025

🦋 Changeset detected

Latest commit: 588e31c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 25 packages
Name Type
@reown/appkit-scaffold-ui Patch
pay-test-exchange Patch
@reown/appkit-adapter-bitcoin Patch
@reown/appkit-adapter-ethers Patch
@reown/appkit-adapter-ethers5 Patch
@reown/appkit-adapter-solana Patch
@reown/appkit-adapter-wagmi Patch
@reown/appkit Patch
@reown/appkit-utils Patch
@reown/appkit-cdn Patch
@reown/appkit-cli Patch
@reown/appkit-codemod Patch
@reown/appkit-common Patch
@reown/appkit-controllers Patch
@reown/appkit-core Patch
@reown/appkit-experimental Patch
@reown/appkit-pay Patch
@reown/appkit-polyfills Patch
@reown/appkit-siwe Patch
@reown/appkit-siwx Patch
@reown/appkit-testing Patch
@reown/appkit-ui Patch
@reown/appkit-universal-connector Patch
@reown/appkit-wallet Patch
@reown/appkit-wallet-button Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link
Copy Markdown

vercel bot commented Sep 4, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
appkit-basic-html Ready Ready Preview Comment Sep 4, 2025 9:02am
appkit-demo Ready Ready Preview Comment Sep 4, 2025 9:02am
appkit-gallery Ready Ready Preview Comment Sep 4, 2025 9:02am
appkit-laboratory Ready Ready Preview Comment Sep 4, 2025 9:02am
10 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
appkit-basic-example Ignored Ignored Sep 4, 2025 9:02am
appkit-basic-sign-client-example Ignored Ignored Sep 4, 2025 9:02am
appkit-basic-up-example Ignored Ignored Sep 4, 2025 9:02am
appkit-ethers5-bera Ignored Ignored Sep 4, 2025 9:02am
appkit-nansen-demo Ignored Ignored Sep 4, 2025 9:02am
appkit-vue-solana Ignored Ignored Sep 4, 2025 9:02am
appkit-wagmi-cdn-example Ignored Ignored Sep 4, 2025 9:02am
ethereum-provider-wagmi-example Ignored Ignored Sep 4, 2025 9:02am
next-wagmi-solana-bitcoin-example Ignored Ignored Sep 4, 2025 9:02am
vue-wagmi-example Ignored Ignored Sep 4, 2025 9:02am

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR makes a minor wording adjustment to improve consistency in UI text by removing the article "an" from "Deposit from an Exchange".

  • Updates the PayWithExchange heading text to remove the article "an"

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@0xmkh 0xmkh changed the title chore: replace "deposit from an exchange" to "deposit from exchange" chore: replace "deposit from an exchange" to "deposit from exchange" in header Sep 4, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 4, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 78.32% 34873 / 44522
🔵 Statements 78.32% 34873 / 44522
🔵 Functions 76.1% 3842 / 5048
🔵 Branches 86.63% 8224 / 9493
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/scaffold-ui/src/partials/w3m-header/index.ts 90.78% 85.1% 77.77% 90.78% 89-90, 151-152, 164, 194, 205, 223, 245, 255, 264, 268-272, 275-280
Generated in workflow #14848 for commit 588e31c by the Vitest Coverage Report Action

@tomiir tomiir merged commit 5595d17 into main Sep 4, 2025
41 checks passed
@tomiir tomiir deleted the chore/rename-exchange-header branch September 4, 2025 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants