feat: increase places for wallets on main view#4963
Merged
Conversation
🦋 Changeset detectedLatest commit: 761549e The changes in this PR will be included in the next version bump. This PR includes changesets to release 24 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
10 Skipped Deployments
|
tomiir
requested review from
0xmkh and
enesozturk
and removed request for
Copilot and
enesozturk
0xmkh
approved these changes
Sep 5, 2025
enesozturk
approved these changes
Sep 5, 2025
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Contributor
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR increases the number of explorer API wallets displayed on the main view from 2 to 4, while refactoring the display logic to show the appropriate number of connectors. The key change ensures that explorer wallets are now displayed alongside featured, custom, email, and social wallets rather than being hidden when those other wallet types are present.
- Increases maximum displayed explorer API wallets from 2 to 4
- Refactors rendering logic to calculate available wallet slots dynamically
- Updates test cases to verify the new display behavior
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| w3m-connect-recommended-widget/index.ts | Implements the core logic for dynamic wallet display calculation and increases maximum wallets to 4 |
| w3m-connect-recommended-widget.test.ts | Updates test cases to validate new rendering behavior and adds mock for auth connector |
| w3m-connector-list/index.ts | Minor refactoring to extract connector logic into a separate variable |
| silly-insects-carry.md | Adds changeset documentation for the feature |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
tomiir
deleted the
tomas/apkt-3686-increase-places-for-wallets-on-main-view
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type of change
Associated Issues
Closes APKT-3686
Showcase (Optional)
Checklist