fix: wallet icon not rendering properly on safari#4965
Merged
Conversation
🦋 Changeset detectedLatest commit: 652cf41 The changes in this PR will be included in the next version bump. This PR includes changesets to release 25 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
10 Skipped Deployments
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where the wallet icon was not rendering properly on Safari browsers. The solution replaces the Phosphor icon system with a custom SVG implementation for the wallet icon.
- Removes wallet icon from Phosphor icon mapping and imports
- Adds a new custom SVG wallet icon implementation
- Updates the icon system to use the custom SVG instead of the Phosphor component
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/ui/src/components/wui-icon/index.ts | Removes Phosphor wallet icon mapping and adds custom SVG wallet icon implementation |
| packages/ui/src/assets/svg/wallet.ts | Creates new custom SVG wallet icon with proper rendering for Safari |
| .changeset/silent-bats-return.md | Documents the bug fix in the changelog |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
enesozturk
approved these changes
Sep 5, 2025
Contributor
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed an issue where the wallet icon from the SIWX screen was not properly rendered on Safari
Type of change
Associated Issues
For Linear issues: Closes APKT-3700
Checklist