fix: send input field missing number pattern validation #4968
Merged
Conversation
🦋 Changeset detectedLatest commit: 5810308 The changes in this PR will be included in the next version bump. This PR includes changesets to release 25 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
10 Skipped Deployments
|
0xmkh
changed the title
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where the swap input field lacked proper number pattern validation when users typed characters. The fix prevents non-numeric characters from being entered by adding HTML pattern validation and implementing proper input filtering logic.
- Added HTML pattern attribute to restrict input to numbers, dots, and commas
- Implemented input filtering to automatically remove non-numeric characters as users type
- Enhanced test coverage for dot-as-first-character handling and non-numeric character filtering
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/scaffold-ui/src/partials/w3m-swap-input/index.ts | Added pattern="[0-9,.]*" attribute to input element for HTML validation |
| packages/scaffold-ui/test/partials/w3m-swap-input.test.ts | Added comprehensive tests for dot handling and non-numeric character filtering |
| .changeset/some-keys-behave.md | Added changeset documentation for the bug fix |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Contributor
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||
enesozturk
reviewed
Sep 6, 2025
enesozturk
reviewed
Sep 6, 2025
enesozturk
approved these changes
Sep 6, 2025
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed an issue where the send input field did not include number pattern validation when typing characters
Type of change
Associated Issues
For Linear issues: Closes APKT-2672
Checklist