fix: open does not throw when attempting to switch network during send flow#4979
Merged
fix: open does not throw when attempting to switch network during send flow#4979
open does not throw when attempting to switch network during send flow#4979Conversation
🦋 Changeset detectedLatest commit: 42e14c6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 25 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
10 Skipped Deployments
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where using the open function with send arguments and attempting to switch networks did not throw errors, which could cause network state inconsistencies.
- Added a
throwIfFailedToSwitchparameter to the network switching flow - Modified
switchActiveNetworkandswitchNetworkmethods to propagate errors when explicitly requested - Added test coverage to verify that network switching failures during send flow properly throw errors
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/controllers/src/controllers/ChainController.ts | Added optional parameter to re-throw network switching errors |
| packages/appkit/src/client/appkit-base-client.ts | Modified to pass error throwing flag during send flow network switches |
| packages/appkit/tests/client/appkit-base-client.test.ts | Added test case to verify error throwing behavior during network switching |
| .changeset/khaki-chairs-start.md | Changelog entry documenting the bug fix |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
tomiir
reviewed
Sep 9, 2025
Contributor
tomiir
approved these changes
Sep 9, 2025
Collaborator
|
nit: I'd rename to |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed an issue where using the
openfunction with send arguments and attempting to switch networks did not throw, causing the network state to become inconsistentType of change
Associated Issues
For Linear issues: Closes APKT-xxx
For GH issues: closes #...
Showcase (Optional)
If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.
Checklist