Skip to content

fix: semver version check#4988

Merged
tomiir merged 2 commits intomainfrom
fix/semver-version-check
Sep 10, 2025
Merged

fix: semver version check#4988
tomiir merged 2 commits intomainfrom
fix/semver-version-check

Conversation

@enesozturk
Copy link
Copy Markdown
Contributor

@enesozturk enesozturk commented Sep 10, 2025

Description

Updates SemVer util's extractVersion logic to handle spacial char prefixes

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-3769
For GH issues: closes #...

Showcase (Optional)

If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

Copilot AI review requested due to automatic review settings September 10, 2025 10:54
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Sep 10, 2025

🦋 Changeset detected

Latest commit: 2b8f32d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 24 packages
Name Type
@reown/appkit-utils Patch
@reown/appkit Patch
@reown/appkit-adapter-bitcoin Patch
@reown/appkit-adapter-ethers Patch
@reown/appkit-adapter-ethers5 Patch
@reown/appkit-adapter-solana Patch
@reown/appkit-adapter-wagmi Patch
@reown/appkit-scaffold-ui Patch
@reown/appkit-siwe Patch
@reown/appkit-siwx Patch
@reown/appkit-wallet-button Patch
@reown/appkit-experimental Patch
@reown/appkit-pay Patch
@reown/appkit-universal-connector Patch
@reown/appkit-cdn Patch
@reown/appkit-testing Patch
@reown/appkit-common Patch
@reown/appkit-ui Patch
@reown/appkit-controllers Patch
@reown/appkit-core Patch
@reown/appkit-polyfills Patch
@reown/appkit-wallet Patch
@reown/appkit-cli Patch
@reown/appkit-codemod Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link
Copy Markdown

vercel bot commented Sep 10, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
appkit-basic-html Ready Ready Preview Comment Sep 10, 2025 10:58am
appkit-demo Ready Ready Preview Comment Sep 10, 2025 10:58am
appkit-gallery Ready Ready Preview Comment Sep 10, 2025 10:58am
appkit-laboratory Ready Ready Preview Comment Sep 10, 2025 10:58am
10 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
appkit-basic-example Ignored Ignored Sep 10, 2025 10:58am
appkit-basic-sign-client-example Ignored Ignored Sep 10, 2025 10:58am
appkit-basic-up-example Ignored Ignored Sep 10, 2025 10:58am
appkit-ethers5-bera Ignored Ignored Sep 10, 2025 10:58am
appkit-nansen-demo Ignored Ignored Sep 10, 2025 10:58am
appkit-vue-solana Ignored Ignored Sep 10, 2025 10:58am
appkit-wagmi-cdn-example Ignored Ignored Sep 10, 2025 10:58am
ethereum-provider-wagmi-example Ignored Ignored Sep 10, 2025 10:58am
next-wagmi-solana-bitcoin-example Ignored Ignored Sep 10, 2025 10:58am
vue-wagmi-example Ignored Ignored Sep 10, 2025 10:58am

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the SemVer utility to handle version range operators and special character prefixes in version strings, addressing an issue with version extraction logic.

  • Updates the extractVersion function to handle semver range operators like ^, ~, >=, <=, <, >
  • Adds comprehensive test coverage for the new functionality including edge cases with whitespace and pre-release suffixes
  • Updates package version from 1.8.2 to 1.8.3

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
packages/appkit/exports/constants.ts Version bump from 1.8.2 to 1.8.3
packages/appkit-utils/src/SemVerUtils.ts Enhanced regex pattern to handle version range operators and whitespace
packages/appkit-utils/tests/SemVerUtil.test.ts Added comprehensive test cases for version range operators and edge cases
.changeset/fancy-llamas-brake.md Changeset documenting the SemVer utility fix

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread .changeset/fancy-llamas-brake.md
@linear
Copy link
Copy Markdown

linear bot commented Sep 10, 2025

@github-actions
Copy link
Copy Markdown
Contributor

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 78.32% 35262 / 45022
🔵 Statements 78.32% 35262 / 45022
🔵 Functions 75.98% 3875 / 5100
🔵 Branches 86.6% 8351 / 9643
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/appkit-utils/src/SemVerUtils.ts 85.91% 91.89% 100% 85.91% 33-40, 53-54, 69
packages/appkit/exports/constants.ts 100% 100% 100% 100%
Generated in workflow #14960 for commit 2b8f32d by the Vitest Coverage Report Action

@tomiir tomiir merged commit 596c364 into main Sep 10, 2025
41 checks passed
@tomiir tomiir deleted the fix/semver-version-check branch September 10, 2025 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants