chore: add message prop to SIWX_AUTH_ERROR event#4990
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
10 Skipped Deployments
|
|
There was a problem hiding this comment.
Pull Request Overview
This PR enhances error tracking for SIWX authentication by adding a message property to the SIWX_AUTH_ERROR event. This provides more detailed information about authentication failures for better debugging and monitoring.
Key changes:
- Added
messageproperty toSIWX_AUTH_ERRORevent type definition - Updated all locations that send
SIWX_AUTH_ERRORevents to include error message - Updated test to verify the new message property is included
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/siwe/scaffold/views/w3m-connecting-siwe-view/index.ts | Added error message to SIWX_AUTH_ERROR event and debug console log |
| packages/controllers/tests/utils/SIWXUtil.test.ts | Updated test to verify message property is included in error event |
| packages/controllers/src/utils/TypeUtil.ts | Added message property to SIWX_AUTH_ERROR event type definition |
| packages/controllers/src/utils/SIWXUtil.ts | Updated all SIWX_AUTH_ERROR event calls to include parsed error message |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||
enesozturk
deleted the
enes/apkt-3749-ops-review-todo-investigate-siwx_auth_error
branch
Description
Adds
messageproperty toSIWX_AUTH_ERRORevent for better error trackingType of change
Associated Issues
For Linear issues: Closes APKT-xxx
For GH issues: closes #...
Showcase (Optional)
If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.
Checklist