Merged
Conversation
🦋 Changeset detectedLatest commit: 1ca9e0c The changes in this PR will be included in the next version bump. This PR includes changesets to release 24 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
10 Skipped Deployments
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds missing message properties to error events across the AppKit codebase, ensuring consistent error reporting in analytics. The changes standardize error event handling by utilizing CoreHelperUtil.parseError() to extract meaningful error messages and include them in event tracking.
Key changes:
- Standardized error message extraction using
CoreHelperUtil.parseError() - Added
messageproperties to social login, payment, and transaction error events - Updated TypeScript type definitions to include optional message fields
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/scaffold-ui/src/views/w3m-wallet-send-preview-view/index.ts | Replaced manual error message parsing with CoreHelperUtil.parseError() for send transaction errors |
| packages/scaffold-ui/src/views/w3m-register-account-name-view/index.ts | Updated name registration error events to use CoreHelperUtil.parseError() |
| packages/scaffold-ui/src/views/w3m-connecting-social-view/index.ts | Added message properties to social login error events with proper error parsing |
| packages/scaffold-ui/src/views/w3m-connecting-farcaster-view/index.ts | Added message property to Farcaster connection error events |
| packages/pay/tests/controllers/PayController.test.ts | Updated test expectations to include message property in PAY_ERROR events |
| packages/pay/src/controllers/PayController.ts | Added message properties to payment error and success events |
| packages/controllers/tests/controllers/ExchangeController.test.ts | Updated test to expect message property in exchange error events |
| packages/controllers/src/utils/TypeUtil.ts | Added optional message field to social login and payment event type definitions |
| packages/controllers/src/utils/ConnectorControllerUtil.ts | Added message properties to social login error events |
| packages/controllers/src/controllers/ExchangeController.ts | Added message property to exchange payment error events |
| .changeset/clean-states-lick.md | Added changeset documentation for the error event updates |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Contributor
0xmkh
approved these changes
Sep 10, 2025
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add missing
messageproperty to error eventsType of change
Associated Issues
For Linear issues: Closes APKT-xxx
For GH issues: closes #...
Showcase (Optional)
If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.
Checklist