feat: custom input amount on deposit from exchange screen#5004
Merged
Conversation
🦋 Changeset detectedLatest commit: 9d97b87 The changes in this PR will be included in the next version bump. This PR includes changesets to release 25 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
10 Skipped Deployments
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds custom input amount functionality to the deposit from exchange screen. Users can now manually edit the deposit amount instead of being limited to preset values only.
- Implemented custom input amount field with mask input utility for user-friendly formatting
- Refactored
<wui-input-amount>component to support fit and auto width variants - Created new
<w3m-fund-input>partial component for the deposit form
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/ui/src/utils/UiHelperUtil.ts | Added maskInput utility function for input formatting with decimal/integer limits |
| packages/ui/tests/UiHelperUtil.test.ts | Added comprehensive test coverage for the new maskInput function |
| packages/ui/src/utils/TypeUtil.ts | Added MaskInputOptions type definition |
| packages/ui/src/composites/wui-input-amount/index.ts | Refactored to support fit/auto width variants and use new mask input utility |
| packages/ui/src/composites/wui-input-amount/styles.ts | Updated styles to support width variants and fit-to-content functionality |
| packages/scaffold-ui/src/partials/w3m-fund-input/index.ts | Created new fund input component |
| packages/scaffold-ui/src/views/w3m-deposit-from-exchange-view/index.ts | Integrated custom input field and updated amount handling |
| packages/controllers/src/controllers/ExchangeController.ts | Fixed token amount calculation using NumberUtil for precision |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
packages/scaffold-ui/src/views/w3m-deposit-from-exchange-view/index.ts
Outdated
Show resolved
Hide resolved
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Contributor
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
enesozturk
reviewed
Sep 12, 2025
tomiir
reviewed
Sep 12, 2025
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
tomiir
approved these changes
Sep 12, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
<w3m-fund-input>partial<w3m-deposit-from-exchange-view>view<wui-input-amount>to support fit and auto width variantsUiHelperUtil.maskInputfor user-friendly input formatting with maximum decimals and integersType of change
Associated Issues
For Linear issues: Closes APKT-3760
Showcase (Optional)
demo.mov
Checklist