fix: wallet buttons not working in the in-app wallet browser#5364
Merged
Conversation
🦋 Changeset detectedLatest commit: 9d2f78b The changes in this PR will be included in the next version bump. This PR includes changesets to release 26 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
10 Skipped Deployments
|
Contributor
Visual Regression Test Results ✅ Passed✨ No visual changes detected Chromatic Build: https://www.chromatic.com/build?appId=6493191bf4b10fed8ca7353f&number=458 |
Contributor
Contributor
📦 Bundle Size Check✅ All bundles are within size limits 📊 View detailed bundle sizes> @reown/appkit-monorepo@1.7.1 size /home/runner/work/appkit/appkit > size-limit |
Contributor
enesozturk
reviewed
Nov 24, 2025
Contributor
enesozturk
left a comment
enesozturk
left a comment
There was a problem hiding this comment.
Can we do this in ConnectorController level instead of adapter level so we don't need to duplicate code over adapters?
Collaborator
Author
|
@enesozturk mhmm i don't think we can do this on |
enesozturk
approved these changes
Nov 24, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed an issue where wallet buttons were not working in the in-app wallet browser
Type of change
Associated Issues
For Linear issues: Closes APKT-4296
Checklist
Note
Populate connector
explorerIdviaPresetsUtil(byrdns/name) in ethers/ethers5 EIP6963 handling and wagmi, with tests and patch bumps.explorerIdfromPresetsUtil.ConnectorExplorerIdsusinginfo.rdnsorinfo.name.explorerIdnow falls back toPresetsUtil.ConnectorExplorerIds[connector.name]whenconnector.idis not mapped.explorerIdis set for EIP6963 (ethers/ethers5) and wagmi connectors.@reown/*packages.Written by Cursor Bugbot for commit 9d2f78b. This will update automatically on new commits. Configure here.