fix: base account triggers coinbase wallet extension connection by 0xmkh · Pull Request #5405 · reown-com/appkit

0xmkh · 2025-12-11T10:20:18Z

Description

Fixed an issue where selecting Base Account incorrectly triggered the Coinbase Wallet extension connection instead of the Base Account SDK connection

Type of change

Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-4267

Checklist

Code in this PR is covered by automated tests (Unit tests, E2E tests)
My changes generate no new warnings
I have reviewed my own code
I have filled out all required sections
I have tested my changes on the preview link
Approver of this PR confirms that the changes are tested on the preview link

Note

Prioritizes Base Account over Coinbase during connector resolution to avoid misrouting to the Coinbase extension; adds unit tests and relaxes Chromatic CI to not fail on visual diffs.

Connectors/Resolution
- Add ConnectorUtil.getPriority and sortConnectorsByPriority to rank connectors (Base Account > Coinbase/SDK > others).
- Use prioritized sorting in ConnectorController.getConnectorById and getConnector to select the correct connector.
Tests
- Add unit tests for sortConnectorsByPriority covering Base Account, Coinbase/SDK ordering, stability, and edge cases.
CI
- Update Chromatic workflow: set exitZeroOnChanges: true and remove failing step so visual diffs don’t fail the workflow.
Release
- Patch bumps across multiple @reown/* packages with changelog entry for the fix.

^{Written by Cursor Bugbot for commit 6d41ef4. This will update automatically on new commits. Configure here.}

changeset-bot · 2025-12-11T10:20:23Z

🦋 Changeset detected

Latest commit: 6d41ef4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 26 packages

Name	Type
@reown/appkit-controllers	Patch
pay-test-exchange	Patch
@reown/appkit-adapter-bitcoin	Patch
@reown/appkit-adapter-ethers	Patch
@reown/appkit-adapter-ethers5	Patch
@reown/appkit-adapter-solana	Patch
@reown/appkit-adapter-ton	Patch
@reown/appkit-adapter-wagmi	Patch
@reown/appkit	Patch
@reown/appkit-utils	Patch
@reown/appkit-cdn	Patch
@reown/appkit-cli	Patch
@reown/appkit-codemod	Patch
@reown/appkit-common	Patch
@reown/appkit-core	Patch
@reown/appkit-experimental	Patch
@reown/appkit-pay	Patch
@reown/appkit-polyfills	Patch
@reown/appkit-scaffold-ui	Patch
@reown/appkit-siwe	Patch
@reown/appkit-siwx	Patch
@reown/appkit-testing	Patch
@reown/appkit-ui	Patch
@reown/appkit-universal-connector	Patch
@reown/appkit-wallet	Patch
@reown/appkit-wallet-button	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel · 2025-12-11T10:20:24Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
appkit-basic-html	Ready	Preview	Comment	Dec 11, 2025 11:24am
appkit-demo	Ready	Preview	Comment	Dec 11, 2025 11:24am
appkit-gallery	Ready	Preview	Comment	Dec 11, 2025 11:24am
appkit-headless-sample-app	Ready	Preview	Comment	Dec 11, 2025 11:24am
appkit-laboratory	Ready	Preview	Comment	Dec 11, 2025 11:24am

10 Skipped Deployments

Project	Deployment	Updated (UTC)
appkit-basic-example	Ignored	Dec 11, 2025 11:24am
appkit-basic-sign-client-example	Ignored	Dec 11, 2025 11:24am
appkit-basic-up-example	Ignored	Dec 11, 2025 11:24am
appkit-ethers5-bera	Ignored	Dec 11, 2025 11:24am
appkit-nansen-demo	Ignored	Dec 11, 2025 11:24am
appkit-vue-solana	Ignored	Dec 11, 2025 11:24am
appkit-wagmi-cdn-example	Ignored	Dec 11, 2025 11:24am
ethereum-provider-wagmi-example	Ignored	Dec 11, 2025 11:24am
next-wagmi-solana-bitcoin-example	Ignored	Dec 11, 2025 11:24am
vue-wagmi-example	Ignored	Dec 11, 2025 11:24am

linear · 2025-12-11T10:21:48Z

APKT-4267 Base Account triggers Coinbase connection

github-actions · 2025-12-11T10:22:24Z

Visual Regression Test Results ✅ Passed

⚠️ 6 visual change(s) detected

Chromatic Build: https://www.chromatic.com/build?appId=6493191bf4b10fed8ca7353f&number=506
Storybook Preview: https://6493191bf4b10fed8ca7353f-lkgqxjnfqm.chromatic.com/

👉 Please review the visual changes in Chromatic and accept or reject them.

packages/controllers/src/utils/ConnectorUtil.ts

github-actions · 2025-12-11T10:30:44Z

📦 Bundle Size Check

✅ All bundles are within size limits

📊 View detailed bundle sizes

> @reown/appkit-monorepo@1.7.1 size /home/runner/work/appkit/appkit

> size-limit

[baseline-browser-mapping] The data in this module is over two months old. To ensure accurate Baseline data, please update: npm i baseline-browser-mapping@latest -D

@reown/appkit - Main Entry
Size limit:   80 kB
Size:         73.96 kB with all dependencies, minified and gzipped
Loading time: 1.5 s    on slow 3G
Running time: 4.2 s    on Snapdragon 410
Total time:   5.6 s
@reown/appkit/react
Size limit:   230 kB
Size:         228.99 kB with all dependencies, minified and gzipped
Loading time: 4.5 s     on slow 3G
Running time: 7.8 s     on Snapdragon 410
Total time:   12.3 s
@reown/appkit/vue
Size limit:   80 kB
Size:         73.96 kB with all dependencies, minified and gzipped
Loading time: 1.5 s    on slow 3G
Running time: 3.1 s    on Snapdragon 410
Total time:   4.5 s
@reown/appkit-scaffold-ui
Size limit:   220 kB
Size:         209.51 kB with all dependencies, minified and gzipped
Loading time: 4.1 s     on slow 3G
Running time: 4.3 s     on Snapdragon 410
Total time:   8.4 s
@reown/appkit-ui
Size limit:   500 kB
Size:         13.15 kB with all dependencies, minified and gzipped
Loading time: 257 ms   on slow 3G
Running time: 422 ms   on Snapdragon 410
Total time:   679 ms

github-actions · 2025-12-11T10:32:23Z

Coverage Report

Status	Category	Percentage	Covered / Total
🔵	Lines	79.77%	38423 / 48162
🔵	Statements	79.77%	38423 / 48162
🔵	Functions	77.25%	4113 / 5324
🔵	Branches	86.45%	9315 / 10774

File Coverage

File	Stmts	Branches	Functions	Lines	Uncovered Lines
Changed Files
packages/controllers/src/controllers/ConnectorController.ts	86.66%	96.15%	74.6%	86.66%	64-66, 84-85, 131-133, 144, 199-200, 226-234, 301-321, 338-343, 420, 424
packages/controllers/src/utils/ConnectorUtil.ts	90.39%	96.59%	66.66%	90.39%	112-119, 169-181, 258, 279-281, 297-302, 469-475, 40, 363

Generated in workflow #16497 for commit 6d41ef4 by the Vitest Coverage Report Action

socket-security · 2025-12-11T10:54:49Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	@walletconnect/sign-client@2.23.0
	@wagmi/vue@0.2.11
	next@14.2.32
	vite@6.3.6
	vite@5.4.20
	valtio@2.1.7

View full report

socket-security · 2025-12-11T10:54:51Z

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action	Severity	Alert (click "▶" to expand/collapse)
Warn		Obfuscated code: npm `vite` is 91.0% likely obfuscated Confidence: 0.91 Location: Package overview From: examples/html-ak-basic-sign-client/package.json → `npm/vite@5.4.20` ℹ Read more on: This package \| This alert \| What is obfuscated code? Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at `support@socket.dev`. Suggestion: Packages should not obfuscate their code. Consider not using packages with obfuscated code. Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment `@SocketSecurity ignore npm/vite@5.4.20`. You can also ignore all packages with `@SocketSecurity ignore-all`. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

github-actions · 2025-12-11T11:00:09Z

	Warnings
⚠️	Workflow file .github/workflows/visual_regression_tests.yml has been modified

Generated by 🚫 dangerJS against 6d41ef4

packages/controllers/src/utils/ConnectorUtil.ts

fix: base account triggers coinbase wallet extension connection

c78d84c

vercel bot deployed to Preview – appkit-basic-html December 11, 2025 10:22 View deployment

cursor bot reviewed Dec 11, 2025

View reviewed changes

packages/controllers/src/utils/ConnectorUtil.ts Outdated Show resolved Hide resolved

vercel bot deployed to Preview – appkit-headless-sample-app December 11, 2025 10:22 View deployment

vercel bot deployed to Preview – appkit-gallery December 11, 2025 10:23 View deployment

0xmkh added 2 commits December 11, 2025 10:23

chore: nit

c1e2f85

chore: make a copy spread

1dca3d4

vercel bot deployed to Preview – appkit-basic-html December 11, 2025 10:26 View deployment

vercel bot deployed to Preview – appkit-headless-sample-app December 11, 2025 10:27 View deployment

vercel bot deployed to Preview – appkit-gallery December 11, 2025 10:27 View deployment

vercel bot deployed to Preview – appkit-laboratory December 11, 2025 10:28 View deployment

vercel bot deployed to Preview – appkit-demo December 11, 2025 10:28 View deployment

chore: cleanup

859b748

vercel bot deployed to Preview – appkit-gallery December 11, 2025 10:48 View deployment

vercel bot deployed to Preview – appkit-headless-sample-app December 11, 2025 10:48 View deployment

vercel bot deployed to Preview – appkit-basic-html December 11, 2025 10:48 View deployment

vercel bot deployed to Preview – appkit-demo December 11, 2025 10:49 View deployment

vercel bot deployed to Preview – appkit-laboratory December 11, 2025 10:50 View deployment

chore: tweak chromatic

7ecdb8e

vercel bot deployed to Preview – appkit-gallery December 11, 2025 10:54 View deployment

vercel bot deployed to Preview – appkit-headless-sample-app December 11, 2025 10:55 View deployment

vercel bot deployed to Preview – appkit-basic-html December 11, 2025 10:55 View deployment

vercel bot deployed to Preview – appkit-laboratory December 11, 2025 10:56 View deployment

vercel bot deployed to Preview – appkit-demo December 11, 2025 10:57 View deployment

enesozturk reviewed Dec 11, 2025

View reviewed changes

packages/controllers/src/utils/ConnectorUtil.ts Show resolved Hide resolved

chore: add descriptor

6d41ef4

vercel bot deployed to Preview – appkit-gallery December 11, 2025 11:22 View deployment

vercel bot deployed to Preview – appkit-headless-sample-app December 11, 2025 11:22 View deployment

vercel bot deployed to Preview – appkit-basic-html December 11, 2025 11:23 View deployment

vercel bot deployed to Preview – appkit-demo December 11, 2025 11:24 View deployment

vercel bot deployed to Preview – appkit-laboratory December 11, 2025 11:24 View deployment

enesozturk approved these changes Dec 11, 2025

View reviewed changes

0xmkh added this pull request to the merge queue Dec 11, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 11, 2025

0xmkh added this pull request to the merge queue Dec 11, 2025

Merged via the queue into main with commit c1954be Dec 11, 2025
45 checks passed

0xmkh deleted the fix/base-account-trigger branch December 11, 2025 12:22

github-actions bot locked and limited conversation to collaborators Dec 11, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: base account triggers coinbase wallet extension connection#5405

fix: base account triggers coinbase wallet extension connection#5405
0xmkh merged 6 commits intomainfrom
fix/base-account-trigger

0xmkh commented Dec 11, 2025 •

edited by cursor bot

Loading

Uh oh!

changeset-bot bot commented Dec 11, 2025 •

edited

Loading

Uh oh!

vercel bot commented Dec 11, 2025 •

edited

Loading

Uh oh!

linear bot commented Dec 11, 2025

Uh oh!

github-actions bot commented Dec 11, 2025 •

edited

Loading

Uh oh!

Uh oh!

github-actions bot commented Dec 11, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Dec 11, 2025 •

edited

Loading

Uh oh!

socket-security bot commented Dec 11, 2025 •

edited

Loading

Uh oh!

socket-security bot commented Dec 11, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Dec 11, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

0xmkh commented Dec 11, 2025 • edited by cursor bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of change

Associated Issues

Checklist

Uh oh!

changeset-bot bot commented Dec 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

vercel bot commented Dec 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

linear bot commented Dec 11, 2025

Uh oh!

github-actions bot commented Dec 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Visual Regression Test Results ✅ Passed

Uh oh!

Uh oh!

github-actions bot commented Dec 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📦 Bundle Size Check

Uh oh!

github-actions bot commented Dec 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report

Uh oh!

socket-security bot commented Dec 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

socket-security bot commented Dec 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Dec 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

0xmkh commented Dec 11, 2025 •

edited by cursor bot

Loading

changeset-bot bot commented Dec 11, 2025 •

edited

Loading

vercel bot commented Dec 11, 2025 •

edited

Loading

github-actions bot commented Dec 11, 2025 •

edited

Loading

github-actions bot commented Dec 11, 2025 •

edited

Loading

github-actions bot commented Dec 11, 2025 •

edited

Loading

socket-security bot commented Dec 11, 2025 •

edited

Loading

socket-security bot commented Dec 11, 2025 •

edited

Loading

github-actions bot commented Dec 11, 2025 •

edited

Loading