Replacing VSWhere with MSBuild.Locator#75
Conversation
This should expand MSBuild discovery to include dotnet SDK installations allowing developers to use other tooling besides Visual Studio (i.e., JetBrains/VSCode/etc.)
|
I had a chance to make a PR based on what was discussed in #74.
All the CI tests pass, but at the moment, I believe the CI tests only run a small portion of the tests, so there's a potential for breakage here. I am also not a JetBrains user, so if you could try it out for us, @ajeckmans, and see if it works better for you locally, that would be awesome. |
|
Thank you @Tiberriver256! This looks good. If @ajeckmans sends an OK signal, we should squash & merge this. Technical side note: In general, I suggest that the ones who are already in the contributors or the core team groups to do the PRs from branches of this repo directly (without forking), because that way it is easier for others (like in this case @ajeckmans) to try it out or even making small fixes. |
|
Sounds good @gasparnagy. I'll plan on using branches moving forward. Let me know if you want me to close this PR and reopen a new one from a branch. |
|
@Tiberriver256 not at all. Was just a comment for the future. |
|
I'll not be able to check this today. It will have to wait till tomorrow. looking at the documentation this will either fix the issue immediately in a Rider only environment because of point 2 of this search order list: https://github.com/microsoft/MSBuildLocator?tab=readme-ov-file#how-locator-searches-for-net-sdk Or it will at least give a way to make it work using any of the other search locations :) |
* system tests concept # Conflicts: # Reqnroll.sln * Update test for problem identified for #54 by @livioc * replace BoDi with Reqnroll.BoDi * portability test POC * Undo 'Microsoft.Build.Locator' for MsBuild location and make it flexible with env vars (#75) * add portability compilation tests with msbuild * Add system tests to CI * Fix system tests to CI * Add TODOs for further portability tests * Fix system tests to CI, take 2 * Change SystemTests to use MsTest * set default target framework to .NET 8.0 * Add .NET Information to CI * test specs filter on CI * Revert "test specs filter on CI" This reverts commit bdcdbaa. * fix specs_filter on CI * speed up build by using heuristics to find MsBuild * speed up build by using global nuget packages folder * cleanup CI script * add CI system test for linux * create Generation test structure * add more categories and exclude .NET Framework and MsBuild tests from linux * Add NUnit and xUnit tests * rename AppConfigDriver to ConfigurationDriver, allow customizing nuget global folder * fix strange test error if .NET 4.6.2 test target was not included in run * Add smoke test * TEST: remove test filter from Linux CI * Add Generation test TODO comments * re-add filter to linux CI * enable parallel system testing * set target fw of Reqnroll.TestProjectGenerator to netstandard2.0 * re-enable all specs tests * code cleanup
4 participants
This should expand MSBuild discovery to include dotnet SDK installations allowing developers to use other tooling besides Visual Studio (i.e., JetBrains/VSCode/etc.)
Types of changes