Fix auto-size for 2d views with RVL encoded depth image not working#12288
Merged
Fix auto-size for 2d views with RVL encoded depth image not working#12288
Conversation
Wumpf
added
📺 re_viewer
Contributor
|
Web viewer built successfully.
View image diff on kitdiff. Note: This comment is updated whenever you push a commit. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an issue where auto-sizing for 2D views was not working correctly when displaying RVL-encoded depth images. Previously, RVL-encoded depth images would return None for their dimensions, preventing proper auto-sizing behavior.
Key changes:
- Added support for parsing RVL metadata to extract image dimensions
- Refactored common image size reading logic into a reusable helper function
- Added
re_rvldependency to enable RVL metadata parsing
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
crates/viewer/re_view_spatial/src/max_image_dimension_subscriber.rs |
Implemented RVL metadata parsing for depth images and extracted common image reading logic into read_image_size_via_image_library helper function |
crates/viewer/re_view_spatial/Cargo.toml |
Added re_rvl dependency and reordered dependencies alphabetically |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
oxkitsune
approved these changes
Dec 19, 2025
Co-authored-by: Gijs de Jong <14833076+oxkitsune@users.noreply.github.com>
ntjohnson1
pushed a commit
that referenced
this pull request
Dec 19, 2025
…12288) Co-authored-by: Gijs de Jong <14833076+oxkitsune@users.noreply.github.com>
ntjohnson1
removed
the
consider-patch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See title ;-). Bit nieche, but annoying when it hits.