RFC: Add Windows Hypervisor Platform APIs#767
Draft
benpye wants to merge 1 commit intoretep998:0.3from
Draft
Conversation
retep998
added
the
waiting on author
Owner
|
Because |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm looking to get some advice on how to get this merged. This adds the Windows Hypervisor Platform APIs.
There is one type that has been especially troublesome,
WHV_UINT128. It represents a 128 bit integer. I have had to manually specify the alignment on it and all unions using it to ensure it has the correct 16 byte alignment. Unfortunatelyu128in Rust is not stable over the FFI boundary and in any case, it currently has the wrong alignment, see rust-lang/rust#54341It seems to me that at least the following still need doing: