Added Close method to QueryExecutor interface and Mock implementation#427
Added Close method to QueryExecutor interface and Mock implementation#427krystsinaetc wants to merge 1 commit intorethinkdb:masterfrom
Conversation
|
This PR is not only adding method to the |
|
@CMogilko Yes, and this is the problem! It would be great to close session somehow: |
|
@CMogilko other solution is to create a separate interface which the same as current interface but additionally includes Close method, could it be worth? Otherwise, I will have to create a new interface in my own program as well as Mock structure with gorethink embedded Mock structure and this Close method. |
|
This PR is useful for testing, but it changes the API, so it can be accepted in v4.0. And it is need more "smart" mocking of |
|
@CMogilko what did you mean "more smart" mocking exactly? |
|
I mean the ability to set error from tests, not only |
I added
Close()method toMock, because without it it's impossible to useMockasQueryExecutorinterface.