Conversation
|
I know it has been a long time, but didn't forget about it. I'll be able to take things from mid January, just to set expectations. |
No worries, i am also busy right now |
gabor-boros
left a comment
gabor-boros
left a comment
There was a problem hiding this comment.
@majst01 better later than never. I left a few comments
| # - name: Lint | ||
| # uses: golangci/golangci-lint-action@v6 | ||
| # with: | ||
| # args: --build-tags integration -p bugs -p unused -D protogetter --timeout=5m |
There was a problem hiding this comment.
We should add a golangci-lint config and enable this CI step
|
|
||
|
|
| # integration: | ||
| # runs-on: ubuntu-latest | ||
| # steps: | ||
| # - name: Checkout | ||
| # uses: actions/checkout@v4 | ||
|
|
||
| # - name: Setup Go | ||
| # uses: actions/setup-go@v5 | ||
| # with: | ||
| # go-version-file: 'go.mod' | ||
|
|
||
| # - name: Run integration tests | ||
| # run: | | ||
| # make integration |
There was a problem hiding this comment.
Is this disabled because we need RethinkDB running? If yes, you may want to check https://github.com/rethinkdb/rethinkdb-python/blob/gabor/python3-v2.5.0/.github/workflows/build.yml#L27-L42 We could follow the same practice here.
|
|
||
| jobs: | ||
| test: | ||
| name: Docker Build |
There was a problem hiding this comment.
This is actually not building docker
| env: | ||
| REGISTRY: ghcr.io | ||
| IMAGE_NAME: ${{ github.repository }} |
There was a problem hiding this comment.
These seems to be unnecessary
| @@ -0,0 +1,56 @@ | |||
| --- | |||
| name: Test | |||
There was a problem hiding this comment.
| name: Test | |
| name: Build and Test |
| @@ -0,0 +1,15 @@ | |||
| --- | |||
| name: Release Drafter Action | |||
There was a problem hiding this comment.
| name: Release Drafter Action | |
| name: Release Draft |
There was a problem hiding this comment.
By the way, I believe we shouldn't do draft releases without waiting for the test pipeline.
|
|
||
| $CHANGES | ||
|
|
||
| categories: |
There was a problem hiding this comment.
As many use conventional commits we may want to follow those labels as well?
2 participants
This introduces CI on Github Actions which executes
make teston every PR. This is required to see the results of the integration tests of #511 and following PRs.@gabor-boros this would be nice to have first.