feat(parser): handle inline comments in PEG command substitution#1006
Open
lu-zero wants to merge 1 commit intoreubeno:mainfrom
Open
feat(parser): handle inline comments in PEG command substitution#1006lu-zero wants to merge 1 commit intoreubeno:mainfrom
lu-zero wants to merge 1 commit intoreubeno:mainfrom
Conversation
Exclude '#' from literal text when inside command context and add comment handling to command_piece() rule. This allows comments within command substitutions to be properly parsed.
Performance Benchmark Report
Code Coverage Report: Only Changed Files listed
Minimum allowed coverage is Test Summary: bash-completion test suite
|
reubeno
requested changes
Feb 23, 2026
Owner
reubeno
left a comment
There was a problem hiding this comment.
I ran the 2 added YAML tests without the fix:
Comment in command substitution without newline fails- it does indeed fail, just with a different error thanbash(so I'd expect the test to pass withignore_stderr: true)Comment in command substitution with newline- passes even without any code changes
Can you identify what case, in particular, you believe is a problem in the current code base?
Contributor
Author
|
If it passes without the change, it is just me repeating the fix I had to make in winnow, but that's strange I was quite sure the original from Gentoo failed even with the stand alone tokenizer... |
Contributor
Author
|
we can just keep the tests and consider later that bit if we want to emit comments and keep the peg parser |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exclude '#' from literal text when inside command context and add comment handling to command_piece() rule. This allows comments within
command substitutions to be properly parsed.