Skip to content

refactor: reexport parser types#784

Merged
reubeno merged 2 commits intomainfrom
reexport-parser-types
Nov 30, 2025
Merged

refactor: reexport parser types#784
reubeno merged 2 commits intomainfrom
reexport-parser-types

Conversation

@reubeno
Copy link
Copy Markdown
Owner

@reubeno reubeno commented Nov 25, 2025

No description provided.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 25, 2025

Test Results

    3 files     23 suites   8m 25s ⏱️
1 284 tests 1 284 ✅ 0 💤 0 ❌
3 832 runs  3 832 ✅ 0 💤 0 ❌

Results for commit d330135.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 25, 2025

Public API changes for crate: brush-core

Added items

+pub use brush_core::SourcePosition
+pub mod brush_core::parser
+pub use brush_core::parser::BindingParseError
+pub use brush_core::parser::ParseError
+pub use brush_core::parser::SourcePosition
+pub use brush_core::parser::SourceSpan
+pub use brush_core::parser::TestCommandParseError
+pub use brush_core::parser::WordParseError
+pub use brush_core::parser::ast

Performance Benchmark Report

Benchmark name Baseline (μs) Test/PR (μs) Delta (μs) Delta %
clone_shell_object 17.40 μs 17.41 μs 0.01 μs ⚪ Unchanged
eval_arithmetic 0.15 μs 0.15 μs -0.00 μs ⚪ Unchanged
expand_one_string 1.74 μs 1.73 μs -0.01 μs ⚪ Unchanged
for_loop 23.60 μs 22.83 μs -0.77 μs 🟢 -3.26%
function_call 2.38 μs 2.35 μs -0.03 μs ⚪ Unchanged
instantiate_shell 54.73 μs 53.98 μs -0.74 μs ⚪ Unchanged
instantiate_shell_with_init_scripts 24543.03 μs 25254.92 μs 711.89 μs 🟠 +2.90%
parse_bash_completion 2019.27 μs 2038.52 μs 19.25 μs ⚪ Unchanged
parse_sample_script 2.00 μs 1.98 μs -0.03 μs 🟢 -1.40%
run_echo_builtin_command 15.73 μs 15.80 μs 0.07 μs ⚪ Unchanged
tokenize_sample_script 3.46 μs 3.48 μs 0.02 μs ⚪ Unchanged

Code Coverage Report: Only Changed Files listed

Package Base Coverage New Coverage Difference
brush-builtins/src/declare.rs 🟢 86.49% 🟢 86.45% 🔴 -0.04%
brush-core/src/sys/unix/signal.rs 🟠 56.36% 🟠 60% 🟢 3.64%
Overall Coverage 🟢 73.97% 🟢 73.98% 🟢 0.01%

Minimum allowed coverage is 70%, this run produced 73.98%

Test Summary: bash-completion test suite

Outcome Count Percentage
✅ Pass 1353 64.15
❗️ Error 216 10.24
❌ Fail 187 8.87
⏩ Skip 338 16.03
❎ Expected Fail 14 0.66
✔️ Unexpected Pass 1 0.05
📊 Total 2109 100.00

@reubeno reubeno force-pushed the reexport-parser-types branch from 59063af to d330135 Compare November 30, 2025 01:34
@reubeno reubeno marked this pull request as ready for review November 30, 2025 01:35
@reubeno reubeno merged commit c1aa9ad into main Nov 30, 2025
43 checks passed
@reubeno reubeno deleted the reexport-parser-types branch November 30, 2025 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants