perf: optimize filterable op mechanism for no-filter case#839
Merged
perf: optimize filterable op mechanism for no-filter case#839
Conversation
- Add #[inline] to do_with_filter to enable better optimization - Split slow path into separate #[cold] function to optimize branch prediction - The common case (no filter) now has minimal overhead with better inlining Co-authored-by: reubeno <10508433+reubeno@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Analyze and propose changes to reduce no-op overhead
perf: optimize filterable op mechanism for no-filter case
Dec 10, 2025
reubeno
pushed a commit
that referenced
this pull request
Dec 14, 2025
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
reubeno
pushed a commit
that referenced
this pull request
Dec 15, 2025
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The filterable op mechanism introduced measurable overhead even when no filters are installed, as shown by benchmark regressions.
Changes
brush-core/src/filter.rs:#[inline]todo_with_filterto enable call-site inliningdo_with_filter_slowmarked#[cold]Impact
For the no-filter case (the common path):
#[inline]allows the compiler to optimize away theNonecheck#[cold]on the slow path improves branch predictionThe clone of
Option<Arc<Mutex<F>>>at call sites remains necessary due to borrow checker constraints (closures need owned values), but it's cheap (atomic increment).💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.