Skip to content

fix(completion): fix issues with completion escaping#956

Draft
reubeno wants to merge 1 commit intomainfrom
completion-escaping
Draft

fix(completion): fix issues with completion escaping#956
reubeno wants to merge 1 commit intomainfrom
completion-escaping

Conversation

@reubeno
Copy link
Copy Markdown
Owner

@reubeno reubeno commented Jan 24, 2026

No description provided.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 24, 2026

Test Results

    3 files     32 suites   12m 34s ⏱️
1 896 tests 1 896 ✅ 0 💤 0 ❌
5 660 runs  5 660 ✅ 0 💤 0 ❌

Results for commit f11a885.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 24, 2026

Public API changes for crate: brush-core

Added items

+pub brush_core::completion::ProcessingOptions::quote_char: core::option::Option<char>

Performance Benchmark Report

Benchmark name Baseline (μs) Test/PR (μs) Delta (μs) Delta %
clone_shell_object 18.10 μs 17.92 μs -0.17 μs 🟢 -0.96%
eval_arithmetic 0.13 μs 0.13 μs -0.00 μs ⚪ Unchanged
expand_one_string 1.57 μs 1.53 μs -0.04 μs ⚪ Unchanged
for_loop 21.82 μs 21.52 μs -0.30 μs 🟢 -1.38%
full_peg_complex 55.86 μs 55.76 μs -0.10 μs ⚪ Unchanged
full_peg_for_loop 6.35 μs 6.37 μs 0.02 μs ⚪ Unchanged
full_peg_nested_expansions 16.32 μs 16.29 μs -0.04 μs ⚪ Unchanged
full_peg_pipeline 4.20 μs 4.22 μs 0.03 μs ⚪ Unchanged
full_peg_simple 1.74 μs 1.76 μs 0.03 μs ⚪ Unchanged
function_call 2.24 μs 2.21 μs -0.04 μs ⚪ Unchanged
instantiate_shell 52.14 μs 53.33 μs 1.19 μs ⚪ Unchanged
instantiate_shell_with_init_scripts 23078.53 μs 23043.93 μs -34.59 μs ⚪ Unchanged
parse_peg_bash_completion 2205.69 μs 2241.06 μs 35.37 μs 🟠 +1.60%
parse_peg_complex 18.71 μs 18.10 μs -0.61 μs 🟢 -3.25%
parse_peg_for_loop 1.88 μs 1.87 μs -0.00 μs ⚪ Unchanged
parse_peg_pipeline 1.97 μs 1.99 μs 0.02 μs 🟠 +1.17%
parse_peg_simple 1.06 μs 1.05 μs -0.01 μs ⚪ Unchanged
run_echo_builtin_command 11.67 μs 11.55 μs -0.12 μs ⚪ Unchanged
tokenize_sample_script 3.53 μs 3.56 μs 0.03 μs ⚪ Unchanged

Code Coverage Report: Only Changed Files listed

Package Base Coverage New Coverage Difference
brush-builtins/src/bind.rs 🟠 74.24% 🟠 69.33% 🔴 -4.91%
brush-core/src/completion.rs 🟠 69.94% 🟠 72.27% 🟢 2.33%
brush-core/src/pathsearch.rs 🔴 28.13% 🟢 88.24% 🟢 60.11%
brush-core/src/results.rs 🟢 80.16% 🟢 83.33% 🟢 3.17%
brush-core/src/shell/fs.rs 🟢 90.18% 🟢 98.21% 🟢 8.03%
brush-interactive/src/basic/term_line_reader.rs 🔴 38.95% 🔴 38.34% 🔴 -0.61%
brush-parser/src/ast.rs 🔴 45.33% 🔴 45.21% 🔴 -0.12%
Overall Coverage 🟢 74.39% 🟢 74.62% 🟢 0.23%

Minimum allowed coverage is 70%, this run produced 74.62%

Test Summary: bash-completion test suite

Outcome Count Percentage
✅ Pass 1541 73.07
❗️ Error 18 0.85
❌ Fail 196 9.29
⏩ Skip 339 16.07
❎ Expected Fail 13 0.62
✔️ Unexpected Pass 2 0.09
📊 Total 2109 100.00

@reubeno reubeno force-pushed the completion-escaping branch from 95cbfb2 to f11a885 Compare February 18, 2026 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant