This repository was archived by the owner on Jan 28, 2026. It is now read-only.
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Hi 👋 We couldn't create a preview environment for this pull-request 😥 You can see your environment build logs here. Please double-check your If you need help, email us at contact@getergomake.com or join Discord. Click here to disable Ergomake. |
awtkns
approved these changes
Jul 12, 2023
awtkns
reviewed
Jul 12, 2023
awtkns
reviewed
Jul 12, 2023
| response = requests.get(self.input_config.url) | ||
| code = response.status_code | ||
| except RequestException: | ||
| code = None |
Contributor
There was a problem hiding this comment.
might be good to log something?
Contributor
Author
There was a problem hiding this comment.
Yeah we need better logging throughout
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Splitting up for a smaller PR