Skip to content
This repository was archived by the owner on Jan 28, 2026. It is now read-only.

feat: add combobox for model names#106

Merged
asim-shrestha merged 15 commits intomainfrom
feat-33_add_picklist_for_model_names
Apr 15, 2023
Merged

feat: add combobox for model names#106
asim-shrestha merged 15 commits intomainfrom
feat-33_add_picklist_for_model_names

Conversation

@Jshen123
Copy link
Copy Markdown
Contributor

@Jshen123 Jshen123 commented Apr 14, 2023 •
edited
Loading

Description:
Editable Combobox for model name
image

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 14, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
agent-gpt ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 15, 2023 6:45pm

@Jshen123
Copy link
Copy Markdown
Contributor Author

Jshen123 commented Apr 14, 2023

@awtkns , this PR will also resolve #98

@awtkns
Copy link
Copy Markdown
Contributor

awtkns commented Apr 14, 2023

Ideally we want to use something this for form elements like this. They are unstyled but implement things like keyboard nav etc..

@awtkns
Copy link
Copy Markdown
Contributor

awtkns commented Apr 14, 2023

@Jshen123 It would also be good to give the option to input something that is not there :)

We can however merge this and improve after. up to you

awtkns
awtkns approved these changes Apr 14, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@awtkns awtkns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please see my comments :)

@Jshen123
Copy link
Copy Markdown
Contributor Author

Jshen123 commented Apr 14, 2023 •
edited
Loading

@Jshen123 It would also be good to give the option to input something that is not there :)

We can however merge this and improve after. up to you

Hey @awtkns, I like the added flexibility. I have opened another PR that merges into this one with the editable option
(#115)
image

tbh, I can see upside in both. @asim-shrestha what do you think?

@Jshen123
Copy link
Copy Markdown
Contributor Author

Jshen123 commented Apr 14, 2023

Ideally we want to use something this for form elements like this. They are unstyled but implement things like keyboard nav etc..

good call! we should definitely address accessibility in a later PR

@Jshen123
Copy link
Copy Markdown
Contributor Author

Jshen123 commented Apr 15, 2023

Hi @awtkns merged in editable combobox PR! ready for PR to main ✅

@awtkns
Copy link
Copy Markdown
Contributor

awtkns commented Apr 15, 2023

@Jshen123 seems there are some merge conflicts

@Jshen123
Copy link
Copy Markdown
Contributor Author

Jshen123 commented Apr 15, 2023

@Jshen123 seems there are some merge conflicts

Resolved!

@asim-shrestha asim-shrestha merged commit a5aeabb into main Apr 15, 2023
@asim-shrestha asim-shrestha deleted the feat-33_add_picklist_for_model_names branch May 18, 2023 18:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@asim-shrestha asim-shrestha Awaiting requested review from asim-shrestha

1 more reviewer

@awtkns awtkns awtkns approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Jshen123 @awtkns @AmetuerCodr @asim-shrestha