This repository was archived by the owner on Jan 28, 2026. It is now read-only.
feat: auto focus on first input on app load#139
Merged
awtkns merged 1 commit intoreworkd:mainfrom Apr 16, 2023
Merged
Conversation
|
Someone is attempting to deploy a commit to the reworkd Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
Author
|
@asim-shrestha @awtkns please merge 😄 |
Closed
naeem-gitonga
force-pushed
the
feat/autofocus-dialog-input
branch
from
bd96799 to
9d7c6ea
Compare
naeem-gitonga
changed the title
awtkns
approved these changes
Apr 16, 2023
Contributor
awtkns
left a comment
awtkns
left a comment
There was a problem hiding this comment.
Thanks for the tag! This looks good!
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update - autofocus the first input element of the Settings Dialog component when component is shown (better UX).
Small refactor to destructure props of
SettingsDialogcomponent inside of component (for better readability/maintainability) and creation ofSettingsDialogPropsinterface (also for better readability/maintainability). Same done on InputProps.